Skip to content

Commit 19e639f

Browse files
larseggertlarseggert
authored
fix: .visually-hidden -> .d-none (ietf-tools#3800)
In bs5, `.visually-hidden` is the equivalent of bs3's `.sr-only`, i.e., it's still shown on screen readers, which is not what we want. Use `.d-none` instead, which is the equivalent of bs3's `.hidden`.
1 parent 2247a36 commit 19e639f

29 files changed

Lines changed: 101 additions & 101 deletions

‎ietf/doc/templatetags/ietf_filters.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -413,7 +413,7 @@ def format_snippet(text, trunc_words=25):
413413
full = keep_spacing(collapsebr(linebreaksbr(mark_safe(sanitize_fragment(text)))))
414414
snippet = truncatewords_html(full, trunc_words)
415415
if snippet != full:
416-
return mark_safe('<div class="snippet">%s<button type="button" aria-label="Expand" class="btn btn-sm btn-primary show-all"><i class="bi bi-caret-down"></i></button></div><div class="visually-hidden full">%s</div>' % (snippet, full))
416+
return mark_safe('<div class="snippet">%s<button type="button" aria-label="Expand" class="btn btn-sm btn-primary show-all"><i class="bi bi-caret-down"></i></button></div><div class="d-none full">%s</div>' % (snippet, full))
417417
return mark_safe(full)
418418

419419
@register.simple_tag

‎ietf/static/js/complete-review.js‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,11 @@ $(document)
3838
mailArchiveSearch.find(".search")
3939
.prop("disabled", true);
4040
mailArchiveSearch.find(".error")
41-
.addClass("visually-hidden");
41+
.addClass("d-none");
4242
mailArchiveSearch.find(".retrieving")
43-
.removeClass("visually-hidden");
43+
.removeClass("d-none");
4444
mailArchiveSearch.find(".results")
45-
.addClass("visually-hidden");
45+
.addClass("d-none");
4646

4747
retrievingData = $.ajax({
4848
url: searchMailArchiveUrl,
@@ -58,7 +58,7 @@ $(document)
5858
mailArchiveSearch.find(".search")
5959
.prop("disabled", false);
6060
mailArchiveSearch.find(".retrieving")
61-
.addClass("visually-hidden");
61+
.addClass("d-none");
6262

6363
var err = data.error;
6464
if (!err && (!data.messages || !data.messages.length))
@@ -67,7 +67,7 @@ $(document)
6767
var non_reply_row = null;
6868
if (err) {
6969
var errorDiv = mailArchiveSearch.find(".error");
70-
errorDiv.removeClass("visually-hidden");
70+
errorDiv.removeClass("d-none");
7171
errorDiv.find(".content")
7272
.text(err);
7373
if (data.query && data.query_url && data.query_data_url) {
@@ -78,11 +78,11 @@ $(document)
7878
errorDiv.find(".try-yourself .query-data-url")
7979
.prop("href", data.query_data_url);
8080
errorDiv.find(".try-yourself")
81-
.removeClass("visually-hidden");
81+
.removeClass("d-none");
8282
}
8383
} else {
8484
mailArchiveSearch.find(".results")
85-
.removeClass("visually-hidden");
85+
.removeClass("d-none");
8686

8787
var results = mailArchiveSearch.find(".results .list-group");
8888
results.children()
@@ -119,10 +119,10 @@ $(document)
119119
mailArchiveSearch.find(".search")
120120
.prop("disabled", false);
121121
mailArchiveSearch.find(".retrieving")
122-
.addClass("visually-hidden");
122+
.addClass("d-none");
123123

124124
var errorDiv = mailArchiveSearch.find(".error");
125-
errorDiv.removeClass("visually-hidden");
125+
errorDiv.removeClass("d-none");
126126
errorDiv.find(".content")
127127
.text("Error trying to retrieve data from mailing list archive.");
128128
});

‎ietf/static/js/edit-meeting-timeslots-and-misc-sessions.js‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ jQuery(document)
4747
content.find(".selected")
4848
.removeClass("selected");
4949

50-
schedulingPanel.addClass("visually-hidden");
50+
schedulingPanel.addClass("d-none");
5151
schedulingPanel.find(".panel-content")
5252
.children()
5353
.remove();
@@ -109,7 +109,7 @@ jQuery(document)
109109
.val(this.dataset.room);
110110
schedulingPanel.find("[name=type]")
111111
.trigger("change");
112-
schedulingPanel.removeClass("visually-hidden");
112+
schedulingPanel.removeClass("d-none");
113113
schedulingPanel.find("[name=time]")
114114
.trigger("focus");
115115
});
@@ -147,8 +147,8 @@ jQuery(document)
147147
schedulingPanel.find(".timeslot-form [name=type]")
148148
.trigger("change");
149149
schedulingPanel.find(".timeslot-form")
150-
.removeClass("visually-hidden");
151-
schedulingPanel.removeClass("visually-hidden");
150+
.removeClass("d-none");
151+
schedulingPanel.removeClass("d-none");
152152
});
153153
});
154154

@@ -161,31 +161,31 @@ jQuery(document)
161161
form.find("[name=group],[name=short],[name=\"agenda_note\"]")
162162
.prop('disabled', false)
163163
.closest(".mb-3")
164-
.removeClass("visually-hidden");
164+
.removeClass("d-none");
165165

166166
if (this.value == "break") {
167167
form.find("[name=short]")
168168
.closest(".mb-3")
169-
.addClass("visually-hidden");
169+
.addClass("d-none");
170170
} else if (this.value == "plenary") {
171171
let group = form.find("[name=group]");
172172
group.val(group.data('ietf'));
173173
} else if (this.value == "regular") {
174174
form.find("[name=short]")
175175
.closest(".mb-3")
176-
.addClass("visually-hidden");
176+
.addClass("d-none");
177177
}
178178

179179
if (this.value != "regular")
180180
form.find("[name=\"agenda_note\"]")
181181
.closest(".mb-3")
182-
.addClass("visually-hidden");
182+
.addClass("d-none");
183183

184184
if (['break', 'reg', 'reserved', 'unavail', 'regular'].indexOf(this.value) != -1) {
185185
let group = form.find("[name=group]");
186186
group.prop('disabled', true);
187187
group.closest(".mb-3")
188-
.addClass("visually-hidden");
188+
.addClass("d-none");
189189
}
190190
});
191191

‎ietf/static/js/edit-milestones.js‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ $(document)
2121
.addClass("changed");
2222
setSubmitButtonState();
2323
if (switch_date_use_form) {
24-
switch_date_use_form.addClass("visually-hidden");
24+
switch_date_use_form.addClass("d-none");
2525
}
2626
}
2727

@@ -36,7 +36,7 @@ $(document)
3636
var action;
3737
var milestone_cnt = milestonesForm.find(".milestonerow")
3838
.length;
39-
var milestone_hidden_cnt = milestonesForm.find(".edit-milestone.visually-hidden")
39+
var milestone_hidden_cnt = milestonesForm.find(".edit-milestone.d-none")
4040
.length;
4141
var milestone_change_cnt = milestonesForm.find(".edit-milestone.changed")
4242
.length;
@@ -53,18 +53,18 @@ $(document)
5353
var submit = milestonesForm.find("[type=submit]");
5454
submit.text(submit.data("label" + action));
5555
if (milestone_change_cnt + milestone_delete_cnt > 0 || action == "review") {
56-
submit.removeClass("visually-hidden");
56+
submit.removeClass("d-none");
5757
} else {
58-
submit.addClass("visually-hidden");
58+
submit.addClass("d-none");
5959
}
6060
}
6161

6262
milestonesForm.find(".milestone")
6363
.on("click", function () {
6464
var row = $(this),
6565
editRow = row.next(".edit-milestone");
66-
row.addClass("visually-hidden");
67-
editRow.removeClass("visually-hidden");
66+
row.addClass("d-none");
67+
editRow.removeClass("d-none");
6868

6969
editRow.find('input[name$="desc"]')
7070
.trigger("focus");
@@ -79,8 +79,8 @@ $(document)
7979
.next('.edit-milestone');
8080
if (e.is(":visible") && !e.hasClass("changed")) {
8181
$(this)
82-
.removeClass("visually-hidden");
83-
e.addClass("visually-hidden");
82+
.removeClass("d-none");
83+
e.addClass("d-none");
8484
}
8585
});
8686
});
@@ -127,7 +127,7 @@ $(document)
127127
});
128128

129129
new_edit_milestone.removeClass("template");
130-
new_edit_milestone.removeClass("visually-hidden");
130+
new_edit_milestone.removeClass("d-none");
131131

132132
new_edit_milestone.find(".select2-field")
133133
.each(function () {
@@ -151,12 +151,12 @@ $(document)
151151
.find("[name$=resolved]");
152152
if (resolved) {
153153
reason.closest(".row")
154-
.removeClass("visually-hidden");
154+
.removeClass("d-none");
155155
if (!reason.val())
156156
reason.val(reason.data("default"));
157157
} else {
158158
reason.closest(".row")
159-
.addClass("visually-hidden");
159+
.addClass("d-none");
160160
reason.val("");
161161
}
162162
}
@@ -223,7 +223,7 @@ $(document)
223223
setSubmitButtonState();
224224
setOrderControlValue();
225225
if (switch_date_use_form) {
226-
switch_date_use_form.addClass("visually-hidden");
226+
switch_date_use_form.addClass("d-none");
227227
}
228228
}
229229
};

‎ietf/static/js/ietf.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ $(document)
277277
trigger.parent()
278278
.find(".track-untrack-doc")
279279
.tooltip("hide");
280-
trigger.addClass("visually-hidden");
280+
trigger.addClass("d-none");
281281

282282
var target_unhide = null;
283283
if (trigger.hasClass('review-wish-add-remove-doc')) {
@@ -289,7 +289,7 @@ $(document)
289289
trigger.parent()
290290
.find(target_unhide)
291291
.not(trigger)
292-
.removeClass("visually-hidden");
292+
.removeClass("d-none");
293293
}
294294
}
295295
}
@@ -327,8 +327,8 @@ $(document)
327327
.on("click", function () {
328328
$(this)
329329
.parents(".snippet")
330-
.addClass("visually-hidden")
330+
.addClass("d-none")
331331
.siblings(".full")
332-
.removeClass("visually-hidden");
332+
.removeClass("d-none");
333333
});
334334
});

‎ietf/static/js/ipr-edit.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,13 @@ $(document)
66
.on("click", function () {
77
var template = form.find('.draft-row.template');
88
var el = template.clone(true)
9-
.removeClass("template visually-hidden");
9+
.removeClass("template d-none");
1010

1111
var totalField = $('#id_iprdocrel_set-TOTAL_FORMS');
1212
var total = +totalField.val();
1313

1414
el.find("*[for*=iprdocrel], *[id*=iprdocrel], *[name*=iprdocrel]")
15-
.not(".visually-hidden")
15+
.not(".d-none")
1616
.each(function () {
1717
var x = $(this);
1818
["for", "id", "name"].forEach(function (at) {

‎ietf/static/js/list.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ $(document)
7777
.text()
7878
.trim() == "") {
7979
// console.log("No headers fields visible, hiding header row.");
80-
header_row.addClass("visually-hidden");
80+
header_row.addClass("d-none");
8181
}
8282

8383
// HTML for the search widget
@@ -99,7 +99,7 @@ $(document)
9999
.children("button.search-reset");
100100

101101
var pager = $.parseHTML(`
102-
<nav aria-label="Pagination control" class="visually-hidden">
102+
<nav aria-label="Pagination control" class="d-none">
103103
<ul class="pagination d-flex flex-wrap text-center"></ul>
104104
</nav>`);
105105

@@ -170,7 +170,7 @@ $(document)
170170
if (pagination) {
171171
// console.log("Enabling pager.");
172172
$(pager)
173-
.removeClass("visually-hidden");
173+
.removeClass("d-none");
174174
pagination = {
175175
innerWindow: 5,
176176
left: 1,

‎ietf/static/js/meeting-interim-request.js‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ const interimRequest = (function() {
7979
totalField.val(total);
8080

8181
template.before(el);
82-
el.removeClass("template visually-hidden");
82+
el.removeClass("template d-none");
8383

8484
// copy field contents
8585
const first_session = $(".fieldset:first");
@@ -88,7 +88,7 @@ const interimRequest = (function() {
8888
.val());
8989

9090
$('.btn-delete')
91-
.removeClass("visually-hidden");
91+
.removeClass("d-none");
9292
},
9393

9494
updateInfo: function () {
@@ -153,9 +153,9 @@ const interimRequest = (function() {
153153
const meeting_type = $('input[name="meeting_type"]:checked')
154154
.val();
155155
if (meeting_type === 'single') {
156-
interimRequest.addButton.addClass("visually-hidden");
156+
interimRequest.addButton.addClass("d-none");
157157
} else {
158-
interimRequest.addButton.removeClass("visually-hidden");
158+
interimRequest.addButton.removeClass("d-none");
159159
}
160160
},
161161

@@ -208,7 +208,7 @@ const interimRequest = (function() {
208208
totalField.val(total);
209209
if (total === 2) {
210210
$(".btn-delete")
211-
.addClass("visually-hidden");
211+
.addClass("d-none");
212212
}
213213
},
214214

‎ietf/static/js/password_strength.js‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
.closest("form");
2121
widget
2222
.find(".hidden")
23-
.addClass("visually-hidden")
23+
.addClass("d-none")
2424
.removeClass("hidden");
2525

2626
widget
@@ -67,30 +67,30 @@
6767
password_strength_bar.removeClass('bg-success')
6868
.addClass('bg-warning');
6969
password_strength_info.find('.badge')
70-
.removeClass('visually-hidden');
70+
.removeClass('d-none');
7171
} else {
7272
password_strength_bar.removeClass('bg-warning')
7373
.addClass('bg-success');
7474
password_strength_info.find('.badge')
75-
.addClass('visually-hidden');
75+
.addClass('d-none');
7676
}
7777

7878
password_strength_bar.width(((result.score + 1) / 5) * 100 + '%')
7979
.attr('aria-valuenow', result.score + 1);
8080
// henrik@levkowetz.com -- this is the only changed line:
8181
password_strength_info.find('.password_strength_time')
8282
.html(result.crack_times_display.online_no_throttling_10_per_second);
83-
password_strength_info.removeClass('visually-hidden');
83+
password_strength_info.removeClass('d-none');
8484

8585
password_strength_offline_info.find('.password_strength_time')
8686
.html(result.crack_times_display.offline_slow_hashing_1e4_per_second);
87-
password_strength_offline_info.removeClass('visually-hidden');
87+
password_strength_offline_info.removeClass('d-none');
8888
} else {
8989
password_strength_bar.removeClass('bg-success')
9090
.addClass('bg-warning');
9191
password_strength_bar.width('0%')
9292
.attr('aria-valuenow', 0);
93-
password_strength_info.addClass('visually-hidden');
93+
password_strength_info.addClass('d-none');
9494
}
9595
self.match_passwords($(this));
9696
});
@@ -157,18 +157,18 @@
157157
$(confirm_field)
158158
.parent()
159159
.find('.password_strength_info')
160-
.addClass('visually-hidden');
160+
.addClass('d-none');
161161
} else {
162162
$(confirm_field)
163163
.parent()
164164
.find('.password_strength_info')
165-
.removeClass('visually-hidden');
165+
.removeClass('d-none');
166166
}
167167
} else {
168168
$(confirm_field)
169169
.parent()
170170
.find('.password_strength_info')
171-
.addClass('visually-hidden');
171+
.addClass('d-none');
172172
}
173173
}
174174
});

0 commit comments

Comments
 (0)