Skip to content

Commit 2bad0b0

Browse files
committed
Show other completed reviews of a document on page showing the status of a review request. Fixes ietf-tools#2083. Commit ready for merge.
- Legacy-Id: 12596
1 parent 6ca953a commit 2bad0b0

2 files changed

Lines changed: 18 additions & 0 deletions

File tree

ietf/review/models.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -158,6 +158,12 @@ class ReviewRequest(models.Model):
158158
def __unicode__(self):
159159
return u"%s review on %s by %s %s" % (self.type, self.doc, self.team, self.state)
160160

161+
def other_requests(self):
162+
return self.doc.reviewrequest_set.exclude(id=self.id)
163+
164+
def other_completed_requests(self):
165+
return self.other_requests().filter(state_id__in=['completed','part-completed'])
166+
161167
def get_default_review_types():
162168
return ReviewTypeName.objects.filter(slug__in=['early','lc','telechat'])
163169

ietf/templates/doc/review/review_request.html

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,18 @@ <h1>Review request<br><small>{{ review_req.doc.name }}</small></h1>
6767
</tr>
6868
{% endif %}
6969

70+
<tr>
71+
<th></th>
72+
<th>Other Reviews</th>
73+
<td>
74+
{% for req in review_req.other_completed_requests %}
75+
{% if req.reviewer == review_req.reviewer %}<strong>{% endif %}
76+
<a href="{% url "ietf.doc.views_review.review_request" name=req.doc request_id=req.id %}">{{req.team.acronym|capfirst}} {{req.type.name}} review of -{{req.reviewed_rev}} by {{req.reviewer.person.plain_name}}</a> {% if req.reviewed_rev != req.doc.rev %} (<a href="{{ rfcdiff_base_url }}?url1={{ req.doc.name }}-{{ req.reviewed_rev }}&url2={{ req.doc.name }}-{{ req.doc.rev }}">diff</a>){% endif %}</br>
77+
{% if req.reviewer == review_req.reviewer %}</strong>{% endif %}
78+
{% endfor %}
79+
</td>
80+
</tr>
81+
7082
{% if review_req.comment %}
7183
<tr>
7284
<th></th>

0 commit comments

Comments
 (0)