Skip to content

Commit 6ca953a

Browse files
committed
Improve the team review content templates. Related to ietf-tools#2075. Commit ready for merge.
- Legacy-Id: 12595
1 parent fbd2cd4 commit 6ca953a

2 files changed

Lines changed: 13 additions & 13 deletions

File tree

ietf/dbtemplate/migrations/0004_team_review_content_templates.py

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ def forward(apps, schema_editor):
1010
DBTemplate.objects.create(
1111
path='/group/genart/review/content_templates/lc.txt',
1212
title='Template for genart last call reviews',
13-
type_id='plain',
13+
type_id='django',
1414
group=Group.objects.get(acronym='genart'),
1515
content="""I am the assigned Gen-ART reviewer for this draft. The General Area
1616
Review Team (Gen-ART) reviews all IETF documents being processed
@@ -21,11 +21,11 @@ def forward(apps, schema_editor):
2121
2222
<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
2323
24-
Document:
25-
Reviewer:
26-
Review Date:
27-
IETF LC End Date:
28-
IESG Telechat date: (if known)
24+
Document: {{ review_req.doc.name }}-??
25+
Reviewer: {{ review_req.reviewer.person.plain_name }}
26+
Review Date: {{ today }}
27+
IETF LC End Date: {% if review_req.doc.most_recent_ietflc %}{{ review_req.doc.most_recent_ietflc.expires|date:"Y-m-d" }}{% else %}None{% endif %}
28+
IESG Telechat date: {{ review_req.doc.telechat_date|default:'Not scheduled for a telechat }}
2929
3030
Summary:
3131
@@ -39,7 +39,7 @@ def forward(apps, schema_editor):
3939
DBTemplate.objects.create(
4040
path='/group/genart/review/content_templates/telechat.txt',
4141
title='Template for genart telechat reviews',
42-
type_id='plain',
42+
type_id='django',
4343
group=Group.objects.get(acronym='genart'),
4444
content="""I am the assigned Gen-ART reviewer for this draft. The General Area
4545
Review Team (Gen-ART) reviews all IETF documents being processed
@@ -50,11 +50,11 @@ def forward(apps, schema_editor):
5050
5151
<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
5252
53-
Document:
54-
Reviewer:
55-
Review Date:
56-
IETF LC End Date:
57-
IESG Telechat date: (if known)
53+
Document: {{ review_req.doc.name }}-??
54+
Reviewer: {{ review_req.reviewer.person.plain_name }}
55+
Review Date: {{ today }}
56+
IETF LC End Date: {% if review_req.doc.most_recent_ietflc %}{{ review_req.doc.most_recent_ietflc.expires|date:"Y-m-d" }}{% else %}None{% endif %}
57+
IESG Telechat date: {{ review_req.doc.telechat_date|default:'Not scheduled for a telechat' }}
5858
5959
Summary:
6060

ietf/doc/views_review.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -580,7 +580,7 @@ def complete_review(request, name, request_id):
580580
}
581581

582582
try:
583-
initial['review_content'] = render_to_string('/group/%s/review/content_templates/%s.txt' % (review_req.team.acronym, review_req.type.slug), {})
583+
initial['review_content'] = render_to_string('/group/%s/review/content_templates/%s.txt' % (review_req.team.acronym, review_req.type.slug), {'review_req':review_req,'today':datetime.date.today()})
584584
except TemplateDoesNotExist:
585585
pass
586586

0 commit comments

Comments
 (0)