Skip to content

Commit 228a683

Browse files
committed
Don't deliver spurious yang extraction errors for drafts where no yang modules were found.
- Legacy-Id: 13668
1 parent a18cf20 commit 228a683

1 file changed

Lines changed: 7 additions & 4 deletions

File tree

ietf/submit/checkers.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -155,14 +155,17 @@ def check_file_txt(self, path):
155155
sys.stderr = saved_stderr
156156
model_list = extractor.get_extracted_models()
157157
except Exception as exc:
158-
code = 1
159-
err = '\n'.join( [ m for m in [out, err, exc] if m ] )
160-
if err:
161-
code += 1
158+
log("Exception when running xym on %s: %s" % (name, exc))
159+
160+
if not model_list:
161+
# Found no yang modules, don't deliver any YangChecker result
162+
return None, "", 0, 0, []
163+
162164
command = "xym"
163165
cmd_version = VersionInfo.objects.get(command=command).version
164166
message = "%s:\n%s\n\n" % (cmd_version, out.replace('\n\n','\n').strip() if code == 0 else err)
165167

168+
166169
results.append({
167170
"name": name,
168171
"passed": passed,

0 commit comments

Comments
 (0)