Skip to content

Commit a18cf20

Browse files
committed
Removed code which has been marked as unreachable since February/March 2017 without triggering any usage indications.
- Legacy-Id: 13667
1 parent 7dd596e commit a18cf20

7 files changed

Lines changed: 1 addition & 190 deletions

File tree

ietf/doc/urls.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,6 @@
9292
url(r'^%(name)s/edit/submit-to-iesg/$' % settings.URL_REGEXPS, views_draft.to_iesg),
9393
url(r'^%(name)s/edit/resurrect/$' % settings.URL_REGEXPS, views_draft.resurrect),
9494
url(r'^%(name)s/edit/addcomment/$' % settings.URL_REGEXPS, views_doc.add_comment),
95-
url(r'^ajax/internet_draft/?$', views_draft.doc_ajax_internet_draft),
9695

9796
url(r'^%(name)s/edit/stream/$' % settings.URL_REGEXPS, views_draft.change_stream),
9897
url(r'^%(name)s/edit/replaces/$' % settings.URL_REGEXPS, views_draft.replaces),

ietf/doc/views_draft.py

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,6 @@
3535
from ietf.name.models import IntendedStdLevelName, DocTagName, StreamName
3636
from ietf.person.fields import SearchableEmailField
3737
from ietf.person.models import Person, Email
38-
from ietf.secr.lib.template import jsonapi
39-
from ietf.utils import log
4038
from ietf.utils.mail import send_mail, send_mail_message
4139
from ietf.utils.textupload import get_cleaned_text_file_content
4240
from ietf.mailtrigger.utils import gather_address_lists
@@ -278,20 +276,6 @@ def change_stream(request, name):
278276
doc=doc,
279277
))
280278

281-
@jsonapi
282-
def doc_ajax_internet_draft(request):
283-
log.unreachable("07 Mar 2017")
284-
if request.method != 'GET' or not request.GET.has_key('term'):
285-
return { 'success' : False, 'error' : 'No term submitted or not GET' }
286-
q = request.GET.get('term')
287-
results = DocAlias.objects.filter(name__icontains=q)
288-
if (results.count() > 20):
289-
results = results[:20]
290-
elif results.count() == 0:
291-
return { 'success' : False, 'error' : "No results" }
292-
response = [dict(id=r.id, label=r.name) for r in results]
293-
return response
294-
295279
class ReplacesForm(forms.Form):
296280
replaces = SearchableDocAliasesField(required=False)
297281
comment = forms.CharField(widget=forms.Textarea, required=False, strip=False)

ietf/meeting/helpers.py

Lines changed: 0 additions & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,13 @@
1717
import debug # pyflakes:ignore
1818

1919
from ietf.doc.models import Document
20-
from ietf.doc.utils import get_document_content
2120
from ietf.group.models import Group
2221
from ietf.ietfauth.utils import has_role, user_is_person
2322
from ietf.liaisons.utils import get_person_for_user
2423
from ietf.mailtrigger.utils import gather_address_lists
2524
from ietf.person.models import Person
2625
from ietf.meeting.models import Meeting, Schedule, TimeSlot, SchedTimeSessAssignment
2726
from ietf.utils.history import find_history_active_at, find_history_replacements_active_at
28-
from ietf.utils import log
2927
from ietf.utils.mail import send_mail
3028
from ietf.utils.pipe import pipe
3129

@@ -427,46 +425,6 @@ def get_earliest_session_date(formset):
427425
return sorted([f.cleaned_data['date'] for f in formset.forms if f.cleaned_data.get('date')])[0]
428426

429427

430-
def get_interim_initial(meeting):
431-
'''Returns a dictionary suitable to initialize a InterimRequestForm'''
432-
log.unreachable("07 Mar 2017")
433-
initial = {}
434-
initial['group'] = meeting.session_set.first().group
435-
if meeting.city:
436-
initial['in_person'] = True
437-
else:
438-
initial['in_person'] = False
439-
if meeting.session_set.count() > 1:
440-
initial['meeting_type'] = 'multi-day'
441-
else:
442-
initial['meeting_type'] = 'single'
443-
if meeting.session_set.first().status.slug == 'apprw':
444-
initial['approved'] = False
445-
else:
446-
initial['approved'] = True
447-
return initial
448-
449-
450-
def get_interim_session_initial(meeting):
451-
'''Returns a list of dictionaries suitable to initialize a InterimSessionForm'''
452-
log.unreachable("07 Mar 2017")
453-
initials = []
454-
for session in meeting.session_set.all():
455-
initial = {}
456-
initial['date'] = session.official_timeslotassignment().timeslot.time
457-
initial['time'] = session.official_timeslotassignment().timeslot.time
458-
initial['duration'] = session.requested_duration
459-
initial['remote_instructions'] = session.remote_instructions
460-
initial['agenda_note'] = session.agenda_note
461-
doc = session.agenda()
462-
if doc:
463-
path = os.path.join(doc.get_file_path(), doc.filename_with_rev())
464-
initial['agenda'] = get_document_content(os.path.basename(path), path, markup=False)
465-
initials.append(initial)
466-
467-
return initials
468-
469-
470428
def is_meeting_approved(meeting):
471429
"""Returns True if the meeting is approved"""
472430
if meeting.session_set.first().status.slug == 'apprw':
@@ -617,17 +575,6 @@ def send_interim_minutes_reminder(meeting):
617575
cc=cc_list)
618576

619577

620-
def check_interim_minutes():
621-
"""Finds interim meetings that occured 10 days ago, if they don't
622-
have minutes send a reminder."""
623-
log.unreachable("07 Mar 2017")
624-
date = datetime.datetime.today() - datetime.timedelta(days=10)
625-
meetings = Meeting.objects.filter(type='interim', session__status='sched', date=date)
626-
for meeting in meetings:
627-
if not meeting.session_set.first().minutes():
628-
send_interim_minutes_reminder(meeting)
629-
630-
631578
def sessions_post_save(forms):
632579
"""Helper function to perform various post save operations on each form of a
633580
InterimSessionModelForm formset"""

ietf/meeting/models.py

Lines changed: 0 additions & 80 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import pytz
44
import datetime
55
from urlparse import urljoin
6-
import copy
76
import os
87
import re
98
import string
@@ -24,7 +23,6 @@
2423
from ietf.group.utils import can_manage_materials
2524
from ietf.name.models import MeetingTypeName, TimeSlotTypeName, SessionStatusName, ConstraintName, RoomResourceName
2625
from ietf.person.models import Person
27-
from ietf.utils import log
2826
from ietf.utils.storage import NoLocationMigrationFileSystemStorage
2927
from ietf.utils.text import xslugify
3028

@@ -527,24 +525,6 @@ def json_dict(self, host_scheme):
527525
def json_url(self):
528526
return "/meeting/%s/timeslot/%s.json" % (self.meeting.number, self.id)
529527

530-
"""
531-
This routine takes the current timeslot, which is assumed to have no location,
532-
and assigns a room, and then creates an identical timeslot for all of the other
533-
rooms.
534-
"""
535-
def create_concurrent_timeslots(self):
536-
log.unreachable("28 Feb 2017")
537-
rooms = self.meeting.room_set.all()
538-
self.room = rooms[0]
539-
self.save()
540-
for room in rooms[1:]:
541-
ts = copy.copy(self)
542-
ts.id = None
543-
ts.location = room
544-
ts.save()
545-
546-
#self.meeting.create_all_timeslots()
547-
548528
"""
549529
This routine deletes all timeslots which are in the same time as this slot.
550530
"""
@@ -677,25 +657,12 @@ def json_dict(self, host_scheme):
677657
def qs_assignments_with_sessions(self):
678658
return self.assignments.filter(session__isnull=False)
679659

680-
@property
681-
def group_mapping(self):
682-
log.unreachable("28 Feb 2017")
683-
assignments,sessions,total,scheduled = self.group_session_mapping
684-
return assignments
685-
686660
@property
687661
def sessions_that_can_meet(self):
688662
if not hasattr(self, "_cached_sessions_that_can_meet"):
689663
self._cached_sessions_that_can_meet = self.meeting.sessions_that_can_meet.all()
690664
return self._cached_sessions_that_can_meet
691665

692-
# calculate badness of entire schedule
693-
def calc_badness(self):
694-
log.unreachable("28 Feb 2017")
695-
# now calculate badness
696-
assignments = self.group_mapping
697-
return self.calc_badness1(assignments)
698-
699666
def delete_schedule(self):
700667
self.assignments.all().delete()
701668
self.delete()
@@ -739,27 +706,6 @@ def slot_to_the_right(self):
739706
else:
740707
return None
741708

742-
@property
743-
def area(self):
744-
log.unreachable("28 Feb 2017")
745-
if not self.session or not self.session.group:
746-
return ""
747-
if self.session.group.type_id == "irtf":
748-
return "irtf"
749-
if self.timeslot.type_id == "plenary":
750-
return "1plenary"
751-
if not self.session.group.parent or not self.session.group.parent.type_id in ["area","irtf"]:
752-
return ""
753-
return self.session.group.parent.acronym
754-
755-
@property
756-
def slottype(self):
757-
log.unreachable("28 Feb 2017")
758-
if self.timeslot and self.timeslot.type:
759-
return self.timeslot.type.slug
760-
else:
761-
return ""
762-
763709
def json_url(self):
764710
if not hasattr(self, '_cached_json_url'):
765711
self._cached_json_url = "/meeting/%s/agenda/%s/%s/session/%u.json" % (
@@ -854,13 +800,6 @@ def brief_display(self):
854800
elif not self.target and self.person:
855801
return u"%s " % (self.person)
856802

857-
def status(self):
858-
log.unreachable("28 Feb 2017")
859-
if self.active_status is not None:
860-
return self.active_status
861-
else:
862-
return True
863-
864803
def json_url(self):
865804
return "/meeting/%s/constraint/%s.json" % (self.meeting.number, self.id)
866805

@@ -1075,25 +1014,6 @@ def timeslotassignment_for_agenda(self, schedule):
10751014
def official_timeslotassignment(self):
10761015
return self.timeslotassignment_for_agenda(self.meeting.agenda)
10771016

1078-
def unique_constraints(self):
1079-
log.unreachable("28 Feb 2017")
1080-
global constraint_cache_uses, constraint_cache_initials
1081-
constraint_cache_uses += 1
1082-
# this cache keeps the automatic placer from visiting the database continuously
1083-
if self.unique_constraints_dict is not None:
1084-
constraint_cache_initials += 1
1085-
return self.unique_constraints_dict
1086-
self.unique_constraints_dict = dict()
1087-
for constraint in self.constraints():
1088-
self.unique_constraints_dict[constraint.target] = constraint
1089-
1090-
for constraint in self.reverse_constraints():
1091-
# update the constraint if there is a previous one, and
1092-
# it is more important than what we had before
1093-
if not (constraint in self.unique_constraints_dict) or (self.unique_constraints_dict[constraint.source] < constraint):
1094-
self.unique_constraints_dict[constraint.source] = constraint
1095-
return self.unique_constraints_dict
1096-
10971017
def constraints_dict(self, host_scheme):
10981018
constraint_list = []
10991019
for constraint in self.constraints():

ietf/meeting/urls.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@
4343
url(r'^timeslots/edit$', views.edit_timeslots),
4444
url(r'^rooms$', ajax.timeslot_roomsurl),
4545
url(r'^room/(?P<roomid>\d+).json$', ajax.timeslot_roomurl),
46-
url(r'^room/(?P<roomid>\d+)(?:.html)?/?$', views.edit_roomurl),
4746
url(r'^timeslots$', ajax.timeslot_slotsurl),
4847
url(r'^timeslots.json$', ajax.timeslot_slotsurl),
4948
url(r'^timeslot/(?P<slotid>\d+).json$', ajax.timeslot_sloturl),

ietf/meeting/views.py

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@
6060
from ietf.secr.proceedings.utils import handle_upload_file
6161
from ietf.secr.proceedings.proc_utils import (get_progress_stats, post_process, import_audio_files,
6262
import_youtube_video_urls)
63-
from ietf.utils import log
6463
from ietf.utils.mail import send_mail_message
6564
from ietf.utils.pipe import pipe
6665
from ietf.utils.pdf import pdf_pages
@@ -268,34 +267,6 @@ class Meta:
268267
model = Room
269268
exclude = ('meeting',)
270269

271-
@role_required('Secretariat')
272-
def edit_roomurl(request, num, roomid):
273-
log.unreachable("07 Mar 2017")
274-
meeting = get_meeting(num)
275-
276-
try:
277-
room = meeting.room_set.get(pk=roomid)
278-
except Room.DoesNotExist:
279-
raise Http404("No room %u for meeting %s" % (roomid, meeting.name))
280-
281-
if request.POST:
282-
roomform = RoomForm(request.POST, instance=room)
283-
new_room = roomform.save(commit=False)
284-
new_room.meeting = meeting
285-
new_room.save()
286-
roomform.save_m2m()
287-
return HttpResponseRedirect( reverse(edit_timeslots, args=[meeting.number]) )
288-
289-
roomform = RoomForm(instance=room)
290-
meeting_base_url = request.build_absolute_uri(meeting.base_url())
291-
site_base_url = request.build_absolute_uri('/')[:-1] # skip the trailing slash
292-
return render(request, "meeting/room_edit.html",
293-
{"meeting_base_url": meeting_base_url,
294-
"site_base_url": site_base_url,
295-
"editroom": roomform,
296-
"meeting":meeting,
297-
"hide_menu": True,
298-
})
299270

300271
##############################################################################
301272
#@role_required('Area Director','Secretariat')

ietf/utils/mail.py

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
import debug # pyflakes:ignore
2727

2828
import ietf
29-
from ietf.utils.log import log, unreachable
29+
from ietf.utils.log import log
3030
from ietf.utils.text import isascii
3131

3232
# Testing mode:
@@ -165,15 +165,6 @@ def mail_context(request):
165165
else:
166166
return Context()
167167

168-
def send_mail_subj(request, to, frm, stemplate, template, context, *args, **kwargs):
169-
'''
170-
Send an email message, exactly as send_mail(), but the
171-
subject field is a template.
172-
'''
173-
unreachable("03 Mar 2017")
174-
subject = render_to_string(stemplate, context ).replace("\n"," ").strip()
175-
return send_mail(request, to, frm, subject, template, context, *args, **kwargs)
176-
177168
def send_mail(request, to, frm, subject, template, context, *args, **kwargs):
178169
'''
179170
Send an email to the destination [list], with the given return

0 commit comments

Comments
 (0)