Skip to content

Commit 1a76c66

Browse files
committed
Rearrange buttons on review request page to make it easier to figure
out what's the next step - Legacy-Id: 11485
1 parent c1783d4 commit 1a76c66

1 file changed

Lines changed: 28 additions & 13 deletions

File tree

ietf/templates/doc/review/review_request.html

Lines changed: 28 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,6 @@ <h1>Review request<br><small>{{ review_req.doc.name }}</small></h1>
1919
{% else %}
2020
<a href="{% url "doc_view" name=review_req.doc.name %}">{{ review_req.doc.name }}</a>
2121
{% endif %}
22-
23-
{% if can_withdraw_request %}
24-
<a class="btn btn-danger btn-xs" href="{% url "ietf.doc.views_review.withdraw_request" name=doc.name request_id=review_req.pk %}"><span class="fa fa-ban"></span> Withdraw request</a>
25-
{% endif %}
2622
</td>
2723
</tr>
2824

@@ -74,17 +70,29 @@ <h1>Review request<br><small>{{ review_req.doc.name }}</small></h1>
7470
None assigned yet
7571
{% endif %}
7672

77-
{% if can_accept_reviewer_assignment %}
78-
<form style="display:inline" method="post" action="{% url "ietf.doc.views_review.review_request" name=doc.name request_id=review_req.pk %}">{% csrf_token %}<button class="btn btn-default btn-xs" type="submit" name="action" value="accept"><span class="fa fa-check"></span> Accept</button></form>
79-
{% endif %}
80-
81-
{% if can_reject_reviewer_assignment %}
82-
<a class="btn btn-warning btn-xs" href="{% url "ietf.doc.views_review.reject_reviewer_assignment" name=doc.name request_id=review_req.pk %}"><span class="fa fa-ban"></span> Reject</a>
83-
{% endif %}
84-
8573
{% if can_assign_reviewer %}
8674
<a class="btn btn-default btn-xs" href="{% url "ietf.doc.views_review.assign_reviewer" name=doc.name request_id=review_req.pk %}"><span class="fa fa-user"></span> {% if review_req.reviewer %}Reassign{% else %}Assign{% endif %} reviewer</a>
8775
{% endif %}
76+
77+
{% if review_req.reviewer %}
78+
{% if can_reject_reviewer_assignment or can_accept_reviewer_assignment %}
79+
<div class="reviewer-assignment-not-accepted">
80+
{% if review_req.state_id == "requested"%}
81+
<em>Assignment not accepted yet:</em>
82+
{% else %}
83+
<em>Assignment accepted:</em>
84+
{% endif %}
85+
86+
{% if can_reject_reviewer_assignment %}
87+
<a class="btn btn-danger btn-xs" href="{% url "ietf.doc.views_review.reject_reviewer_assignment" name=doc.name request_id=review_req.pk %}"><span class="fa fa-ban"></span> Reject</a>
88+
{% endif %}
89+
90+
{% if can_accept_reviewer_assignment %}
91+
<form style="display:inline" method="post" action="{% url "ietf.doc.views_review.review_request" name=doc.name request_id=review_req.pk %}">{% csrf_token %}<button class="btn btn-success btn-xs" type="submit" name="action" value="accept"><span class="fa fa-check"></span> Accept</button></form>
92+
{% endif %}
93+
</div>
94+
{% endif %}
95+
{% endif %}
8896
</td>
8997
</tr>
9098

@@ -97,7 +105,7 @@ <h1>Review request<br><small>{{ review_req.doc.name }}</small></h1>
97105
{% else %}
98106
Not completed yet
99107
{% endif %}
100-
108+
101109
{% if can_complete_review %}
102110
<a class="btn btn-primary btn-xs" href="{% url "ietf.doc.views_review.complete_review" name=doc.name request_id=review_req.pk %}"><span class="fa fa-pencil-square-o"></span> Complete review</a>
103111
{% endif %}
@@ -132,4 +140,11 @@ <h1>Review request<br><small>{{ review_req.doc.name }}</small></h1>
132140
</tbody>
133141
</table>
134142

143+
<div>
144+
{% if can_withdraw_request %}
145+
<a class="btn btn-danger btn-xs" href="{% url "ietf.doc.views_review.withdraw_request" name=doc.name request_id=review_req.pk %}"><span class="fa fa-ban"></span> Withdraw request</a>
146+
{% endif %}
147+
</div>
148+
149+
135150
{% endblock %}

0 commit comments

Comments
 (0)