Skip to content

Commit c1783d4

Browse files
committed
Bit more polish to the review page
- Legacy-Id: 11370
1 parent f7f6d27 commit c1783d4

2 files changed

Lines changed: 29 additions & 7 deletions

File tree

ietf/doc/views_review.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -390,7 +390,7 @@ def complete_review(request, name, request_id):
390390

391391
review.type = DocTypeName.objects.get(slug="review")
392392
review.rev = "00"
393-
review.title = "Review of {}-{}".format(review_req.doc.name, review_req.reviewed_rev)
393+
review.title = "{} Review of {}-{}".format(review_req.type.name, review_req.doc.name, form.cleaned_data["reviewed_rev"])
394394
review.group = review_req.team
395395
if review_submission == "link":
396396
review.external_url = form.cleaned_data['review_url']

ietf/templates/doc/document_review.html

Lines changed: 28 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,18 +16,19 @@
1616
<thead id="message-row">
1717
<tr>
1818
{% if doc.rev != latest_rev %}
19-
<th colspan="3" class="alert-warning">The information below is for an old version of the document</th>
19+
<th colspan="4" class="alert-warning">The information below is for an old version of the document</th>
2020
{% else %}
21-
<th colspan="3"></th>
21+
<th colspan="4"></th>
2222
{% endif %}
2323
</tr>
2424
</thead>
2525

2626
<tbody class="meta">
2727
<tr>
28-
<th class="col-md-1">Team</th>
29-
<td class="edit col-md-1"></td>
30-
<td class="col-md-10">
28+
<th></th>
29+
<th>Team</th>
30+
<td class="edit"></td>
31+
<td>
3132
{{ doc.group.name }}
3233
<a href="{{ doc.group.about_url }}">({{ doc.group.acronym }})</a>
3334

@@ -38,34 +39,55 @@
3839
</tr>
3940

4041
<tr>
42+
<th></th>
4143
<th>Title</th>
4244
<td class="edit"></td>
4345
<td>{{ doc.title }}</td>
4446
</tr>
4547

48+
{% if doc.get_state_slug != "active" %}
4649
<tr>
50+
<th></th>
4751
<th>State</th>
4852
<td class="edit"></td>
4953
<td>{{ doc.get_state.name }}</td>
5054
</tr>
55+
{% endif %}
5156

5257
{% if review_req %}
5358
<tr>
59+
<th></th>
60+
<th>Request</th>
61+
<td class="edit"></td>
62+
<td>{{ review_req.type.name }} - <a href="{% url "ietf.doc.views_review.review_request" review_req.doc.name review_req.pk %}">requested {{ review_req.time|date:"Y-m-d" }}</a></td>
63+
</tr>
64+
65+
<tr>
66+
<th></th>
67+
<th>Reviewer</th>
68+
<td class="edit"></td>
69+
<td>{{ review_req.reviewer.person }}</td>
70+
</tr>
71+
72+
<tr>
73+
<th></th>
5474
<th>Review result</th>
5575
<td class="edit"></td>
56-
<td><a href="{% url "ietf.doc.views_review.review_request" review_req.doc.name review_req.pk %}">{{ review_req.result.name }}</a></td>
76+
<td>{{ review_req.result.name }}</td>
5777
</tr>
5878
{% endif %}
5979

6080
{% if doc.external_url %}
6181
<tr>
82+
<th></th>
6283
<th>Posted at</th>
6384
<td class="edit"></td>
6485
<td><a href="{{ doc.external_url }}">{{ doc.external_url }}</a></td>
6586
</tr>
6687
{% endif %}
6788

6889
<tr>
90+
<th></th>
6991
<th>Last updated</th>
7092
<td class="edit"></td>
7193
<td>{{ doc.time|date:"Y-m-d" }}</td>

0 commit comments

Comments
 (0)