Comment out unreachable code in rfc-editor-index-updates. Relates to ietf-tools#3491.

 - Legacy-Id: 19779

Author: jennifer-richards

ietf/bin/rfc-editor-index-updates

@@ -5,13 +5,11 @@
 
 import datetime
 import io
-import json
 import os
 import requests
 import socket
 import sys
 import syslog
-import traceback
 
 # boilerplate
 basedir = os.path.abspath(os.path.join(os.path.dirname(__file__), "../.."))
@@ -26,11 +24,8 @@ django.setup()
 
 from django.conf import settings
 from optparse import OptionParser
-from django.core.mail import mail_admins
 
-from ietf.doc.utils import rebuild_reference_relations
 from ietf.utils.log import log
-from ietf.utils.pipe import pipe
 
 import ietf.sync.rfceditor
 
@@ -72,23 +67,41 @@ for changes, doc, rfc_published in ietf.sync.rfceditor.update_docs_from_rfc_inde
 
 sys.exit(0)
 
-# This can be called while processing a notifying POST from the RFC Editor
-# Spawn a child to sync the rfcs and calculate new reference relationships
-# so that the POST
-
-newpid = os.fork()
-
-if newpid == 0:
-    try:
-        pipe("%s -a %s %s" % (settings.RSYNC_BINARY,settings.RFC_TEXT_RSYNC_SOURCE,settings.RFC_PATH))
-        for rfc in new_rfcs:
-            rebuild_reference_relations(rfc)
-            log("Updated references for %s"%rfc.canonical_name())
-    except:
-        subject = "Exception in updating references for new rfcs: %s : %s" % (sys.exc_info()[0],sys.exc_info()[1])
-        msg = "%s\n%s\n----\n%s"%(sys.exc_info()[0],sys.exc_info()[1],traceback.format_tb(sys.exc_info()[2])) 
-        mail_admins(subject,msg,fail_silently=True)
-        log(subject)
-    os._exit(0)
-else:
-    sys.exit(0)
+# The code below has been unreachable for 5 years as of this comment (2021; the sys.exit(0) above
+# has been in place since 2016). I am commenting it out rather than removing it until someone has
+# a chance to review what's going on and, specifically, whether reference relations are actually
+# being updated properly.
+#
+# See trac ticket #3491 for info (and update that if you make progress on this)
+#
+# The call here to rebuild_reference_relations(rfc) relied on that method to deduce the correct
+# filename for rfc. I am taking out that capability because it is not used elsewhere. The code it
+# used to deduce the filename was:
+#
+# if not filename:
+#     if doc.get_state_slug() == 'rfc':
+#         filename=os.path.join(settings.RFC_PATH,doc.canonical_name()+".txt")
+#     else:
+#         filename=os.path.join(settings.INTERNET_DRAFT_PATH,doc.filename_with_rev())
+#
+
+# # This can be called while processing a notifying POST from the RFC Editor
+# # Spawn a child to sync the rfcs and calculate new reference relationships
+# # so that the POST
+#
+# newpid = os.fork()
+#
+# if newpid == 0:
+#     try:
+#         pipe("%s -a %s %s" % (settings.RSYNC_BINARY,settings.RFC_TEXT_RSYNC_SOURCE,settings.RFC_PATH))
+#         for rfc in new_rfcs:
+#             rebuild_reference_relations(rfc)
+#             log("Updated references for %s"%rfc.canonical_name())
+#     except:
+#         subject = "Exception in updating references for new rfcs: %s : %s" % (sys.exc_info()[0],sys.exc_info()[1])
+#         msg = "%s\n%s\n----\n%s"%(sys.exc_info()[0],sys.exc_info()[1],traceback.format_tb(sys.exc_info()[2]))
+#         mail_admins(subject,msg,fail_silently=True)
+#         log(subject)
+#     os._exit(0)
+# else:
+#     sys.exit(0)