Skip to content

Commit 0efc882

Browse files
committed
Merged [4873] from rjsparks@nostrum.com:
Includes the conflict-review document contents in the email sent with the results of the conflict review. Fixes bug ietf-tools#883 - Legacy-Id: 4944 Note: SVN reference [4873] has been migrated to Git commit d6579c6
1 parent 327ae94 commit 0efc882

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

ietf/doc/views_conflict_review.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -286,10 +286,8 @@ def edit_ad(request, name):
286286

287287
def default_approval_text(review):
288288

289-
# Leaving these commented out lines for current_text to make it easy to put the actual review result into the approval email
290-
# message should the stream owners decide that is a good thing.
291-
#filename = "%s-%s.txt" % (review.canonical_name(), review.rev)
292-
#current_text = get_document_content(filename, os.path.join(settings.CONFLICT_REVIEW_PATH, filename), split=False, markup=False)
289+
filename = "%s-%s.txt" % (review.canonical_name(), review.rev)
290+
current_text = get_document_content(filename, os.path.join(settings.CONFLICT_REVIEW_PATH, filename), split=False, markup=False)
293291

294292
conflictdoc = review.relateddocument_set.get(relationship__slug='conflrev').target.document
295293
if conflictdoc.stream_id=='ise':
@@ -304,7 +302,7 @@ def default_approval_text(review):
304302
conflictdoc = conflictdoc,
305303
conflictdoc_url = settings.IDTRACKER_BASE_URL+conflictdoc.get_absolute_url(),
306304
receiver=receiver,
307-
#approved_review = current_text
305+
approved_review = current_text
308306
)
309307
)
310308

ietf/templates/doc/conflict_review/approval_text.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ The IESG recommends that '{{ conflictdoc.title }}' {{ conflictdoc.file_tag|safe
1111
The IESG has no problem with the publication of '{{ conflictdoc.title }}' {{ conflictdoc.file_tag|safe }} as {{ conflictdoc|std_level_prompt_with_article }}.
1212
{% endif %}
1313

14+
{{ approved_review }}
15+
1416
The IESG would also like the {{receiver}} to review the comments in the datatracker related to this document and determine whether or not they merit incorporation into the document. Comments may exist in both the ballot and the history log.
1517

1618
The IESG review is documented at:

0 commit comments

Comments
 (0)