Skip to content

Commit d6579c6

Browse files
committed
Includes the conflict-review document contents in the email sent with the results of the conflict review.
Fixes bug ietf-tools#883 - Legacy-Id: 4873
1 parent d1c27fe commit d6579c6

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

ietf/doc/views_conflict_review.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -272,10 +272,8 @@ def edit_ad(request, name):
272272

273273
def default_approval_text(review):
274274

275-
# Leaving these commented out lines for current_text to make it easy to put the actual review result into the approval email
276-
# message should the stream owners decide that is a good thing.
277-
#filename = "%s-%s.txt" % (review.canonical_name(), review.rev)
278-
#current_text = get_document_content(filename, os.path.join(settings.CONFLICT_REVIEW_PATH, filename), split=False, markup=False)
275+
filename = "%s-%s.txt" % (review.canonical_name(), review.rev)
276+
current_text = get_document_content(filename, os.path.join(settings.CONFLICT_REVIEW_PATH, filename), split=False, markup=False)
279277

280278
conflictdoc = review.relateddocument_set.get(relationship__slug='conflrev').target.document
281279
if conflictdoc.stream_id=='ise':
@@ -290,7 +288,7 @@ def default_approval_text(review):
290288
conflictdoc = conflictdoc,
291289
conflictdoc_url = settings.IDTRACKER_BASE_URL+conflictdoc.get_absolute_url(),
292290
receiver=receiver,
293-
#approved_review = current_text
291+
approved_review = current_text
294292
)
295293
)
296294

ietf/templates/doc/conflict_review/approval_text.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ The IESG recommends that '{{ conflictdoc.title }}' {{ conflictdoc.file_tag|safe
1111
The IESG has no problem with the publication of '{{ conflictdoc.title }}' {{ conflictdoc.file_tag|safe }} as {{ conflictdoc|std_level_prompt_with_article }}.
1212
{% endif %}
1313

14+
{{ approved_review }}
15+
1416
The IESG would also like the {{receiver}} to review the comments in the datatracker related to this document and determine whether or not they merit incorporation into the document. Comments may exist in both the ballot and the history log.
1517

1618
The IESG review is documented at:

0 commit comments

Comments
 (0)