Skip to content

Commit 040e26b

Browse files
committed
Added Additional Resources. Simplified the bofreq urls file.
- Legacy-Id: 19204
1 parent a76961d commit 040e26b

3 files changed

Lines changed: 35 additions & 26 deletions

File tree

ietf/doc/tests_bofreq.py

Lines changed: 2 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -97,15 +97,15 @@ def test_bofreq_main_page(self):
9797
r = self.client.get(url)
9898
self.assertEqual(r.status_code, 200)
9999
q = PyQuery(r.content)
100-
self.assertEqual(5, len(q('td.edit>a.btn')))
100+
self.assertEqual(6, len(q('td.edit>a.btn')))
101101
self.client.logout()
102102
self.assertNotEqual([],q('#change-request'))
103103
editor = editors.first().user.username
104104
self.client.login(username=editor, password=editor+"+password")
105105
r = self.client.get(url)
106106
self.assertEqual(r.status_code,200)
107107
q = PyQuery(r.content)
108-
self.assertEqual(2, len(q('td.edit>a.btn')))
108+
self.assertEqual(3, len(q('td.edit>a.btn')))
109109
self.assertNotEqual([],q('#change-request'))
110110
self.client.logout()
111111
url = urlreverse('ietf.doc.views_doc.document_main', kwargs=dict(name=doc,rev='00'))
@@ -365,21 +365,4 @@ def test_start_new_bofreq(self):
365365
self.assertEqual(r.status_code, 200)
366366
q = PyQuery(r.content)
367367
self.assertTrue(q('form div.has-error'))
368-
369-
def test_change_notify(self):
370-
doc = BofreqFactory()
371-
url = urlreverse('ietf.doc.views_doc.edit_notify;bofreq', kwargs=dict(name=doc.name))
372-
login_testing_unauthorized(self, "secretary", url)
373-
374-
# get
375-
r = self.client.get(url)
376-
self.assertEqual(r.status_code,200)
377-
q = PyQuery(r.content)
378-
self.assertEqual(len(q('form input[name=notify]')),1)
379-
380-
# Provide a list
381-
r = self.client.post(url,dict(notify="TJ2APh2P@ietf.org",save_addresses="1"))
382-
self.assertEqual(r.status_code,302)
383-
doc = reload_db_objects(doc)
384-
self.assertEqual(doc.notify,'TJ2APh2P@ietf.org')
385368

ietf/doc/urls_bofreq.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11

2-
from ietf.doc import views_bofreq, views_doc
2+
from ietf.doc import views_bofreq
33
from ietf.utils.urls import url
44

55
urlpatterns = [
6-
url(r'^notices/$', views_doc.edit_notify, name='ietf.doc.views_doc.edit_notify;bofreq'),
76
url(r'^state/$', views_bofreq.change_state),
87
url(r'^submit/$', views_bofreq.submit),
98
url(r'^title/$', views_bofreq.edit_title),

ietf/templates/doc/document_bofreq.html

Lines changed: 32 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -114,18 +114,45 @@
114114
{% person_link leader %}{% if not forloop.last %}, {% endif %}
115115
{% endfor %}
116116
</td>
117-
118-
</tbody>
119-
120-
<tbody class="meta">
117+
</tr>
118+
119+
{% with doc.docextresource_set.all as resources %}
120+
{% if resources or is_editor or can_manage %}
121+
<tr>
122+
<td></td>
123+
<th>Additional Resources</th>
124+
<td class="edit">
125+
{% if is_editor or can_manage %}
126+
<a class="btn btn-default btn-xs" href="{% url 'ietf.doc.views_draft.edit_doc_extresources' name=doc.name %}">Edit</a>
127+
{% endif %}
128+
</td>
129+
<td>
130+
{% if resources %}
131+
<table class="col-md-12 col-sm-12 col-xs-12">
132+
<tbody>
133+
{% for resource in resources|dictsort:"display_name" %}
134+
{% if resource.name.type.slug == 'url' or resource.name.type.slug == 'email' %}
135+
<tr><td> - <a href="{{ resource.value }}" title="{{resource.name.name}}">{% firstof resource.display_name resource.name.name %}</a></td></tr>
136+
{# Maybe make how a resource displays itself a method on the class so templates aren't doing this switching #}
137+
{% else %}
138+
<tr><td> - <span title="{{resource.name.name}}">{% firstof resource.display_name resource.name.name %}: {{resource.value}}</span></td></tr>
139+
{% endif %}
140+
{% endfor %}
141+
</tbody>
142+
</table>
143+
{% endif %}
144+
</td>
145+
</tr>
146+
{% endif %}
147+
{% endwith %}
121148

122149
<tr>
123150
<td></td>
124151
<th>Send notices to</th>
125152
<td class="edit">
126153
{% if not snapshot %}
127154
{% if can_manage %}
128-
{% doc_edit_button 'ietf.doc.views_doc.edit_notify;bofreq' name=doc.name %}
155+
{% doc_edit_button 'ietf.doc.views_doc.edit_notify' name=doc.name %}
129156
{% endif %}
130157
{% endif %}
131158
</td>

0 commit comments

Comments
 (0)