Use ES6 import instead of require to pull in 'sum' to sum-test#1
Merged
hipertracker merged 1 commit intohipertracker:masterfrom Feb 14, 2015
Merged
Use ES6 import instead of require to pull in 'sum' to sum-test#1hipertracker merged 1 commit intohipertracker:masterfrom
hipertracker merged 1 commit intohipertracker:masterfrom
Conversation
hipertracker
added a commit
that referenced
this pull request
Feb 14, 2015
Use ES6 import instead of require to pull in 'sum' to sum-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test was failing due to use of require instead of ES6 import.
(command output skipped for all except 'npm test')
➜ git clone https://github.com/hipertracker/react-es7.git
Cloning into 'react-es7'...
➜ cd react-es7
➜ npm install
➜ bower install
➜ npm test
Using Jest CLI v0.2.2
FAIL src/tests/sum-test.js (0.477s)
● sum › it adds 1 + 2 to equal 3
at Spec. (/Users/brendon/Experiments/react-es7/src/tests/sum-test.js:9:16)
at jasmine.Block.execute (/Users/brendon/Experiments/react-es7/node_modules/jest-cli/vendor/jasmine/jasmine-1.3.0.js:1065:17)
at jasmine.Queue.next_ (/Users/brendon/Experiments/react-es7/node_modules/jest-cli/vendor/jasmine/jasmine-1.3.0.js:2098:31)
at null._onTimeout (/Users/brendon/Experiments/react-es7/node_modules/jest-cli/vendor/jasmine/jasmine-1.3.0.js:2088:18)
at Timer.listOnTimeout as ontimeout
1 test failed, 0 tests passed (1 total)
Run time: 0.659s
npm ERR! Test failed. See above for more details.