Add incremental APs and disable Google Play services plugin#1
Merged
Conversation
wolfs
requested changes
Aug 9, 2019
Member
wolfs
left a comment
wolfs
left a comment
There was a problem hiding this comment.
Looks good, one question about the google-services.json.
gavra0
changed the title
wolfs
requested changes
Aug 9, 2019
This plugin required creation of google-services.json file which makes local testing difficult.
wolfs
approved these changes
Aug 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates APs to versions that support incremental annotation processing. Also a
santa-tracker/mock-google-services.jsonfile is added in order to avoid creating an actual Firebase project when building the project.