Solidify playback API, rendering pipeline, and coverage#16
Merged
Conversation
- Added explicit Advance/Render API, enforced non-nil sampler in Tick, and migrated callers off Tick. - Pruned unused generics and reflection options, replacing them with typed options/interfaces. - Exposed read-only mixer accessor while keeping legacy pointer compatibility. - Extracted render pipeline stages and isolated OPL2 handling; split channel display into MVVM-style layers. - Documented sampler concurrency expectations and mixer ownership/callback behavior; refreshed examples for new sampler signature. - Expanded focused tests for sequencing vs rendering, option parsing, mixers/panning, filters/DSP, player lifecycle/render, output pipeline, voice components (sampler/envelopes/OPL2), period/frequency math, format loaders (IT/S3M/XM/MOD), registration wiring, tremor, tracing/logging, and utility helpers. - Fixed IT correctness quirks (pan clamping, panbrello/tremolo oscillator choice, disabled channel handling, random-wave delay, muted-but-processing channels). - Stabilized mixing by clamping denormals and matching echo filter semantics to Microsoft behavior. - Added tracker-version quirks framework for opt-in compatibility behaviors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
Advance/RenderAPI alongside compatibilityTick; sequencing and render separation tests.MixerConfig) while keeping legacy pointer for compatibility.Fixed or Changed
Ticknow enforces a non-nil sampler and delegates toAdvance/Render.Removed