Merged
Conversation
- update dependencies - some clean up use of generics
- fix issue with IT sample speed calculations
- simplify period calculations - reuse period patterns - require derivations of period types
- less direct playback structs - simpler playback management
- reenable fadeout code
- split channel processing out to format
- fix issue were instrument envelopes might not get setup properly
- also stub out s3m surround support
- reduces issue with cycle detection misidentifying period package
- also fix mixing overload on virtual outputs
- fix s3m/mod portamentos - fix channel instructions sticking between rows
- implement octave shift for amiga periods (xm/s3m)
- fix up some quirks - clean up period converters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major Rewrite
Added