Various things to make it possible to run on wasm and macOS#3
Merged
Conversation
* Remove unsynchronized goroutine for converting samples - caused unpredictable behaviour on load * Use BE16ToLE16 Linux implementation on all other platforms
Contributor
Author
heucuva
approved these changes
Nov 29, 2022
heucuva
left a comment
heucuva
left a comment
Collaborator
There was a problem hiding this comment.
Looks good - been meaning to get rid of the converters in goroutines - thanks for the fix :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I was trying to use your libraries in a project which runs in browsers and on macOS and stumbled upon two problems which I solved:
This also makes gotracker usable on macOS (it only converts to file, but it's something!)