feat(a11y): enhance keyboard focus order in View All menu page#230
Merged
Conversation
Jezzamonn
approved these changes
Dec 21, 2025
Collaborator
|
Awesome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an accessibility issue in the "View All" menu where the keyboard focus order was unpredictable, causing the tab focus to zig-zag between rows instead of following a logical flow.
Changes
rendermethod insanta-cardnav.jsto pre-calculate the layout position of each card based on the existing bin-packing logic.Impacted UI components
santa-cardnav): The component responsible for rendering the "View All" grid menu.