Skip to content

Make snowdodgeball better on different screen sizes#225

Merged
Jezzamonn merged 3 commits into
google:mainfrom
saranshsaini:reactive-snowdodgeball
Dec 16, 2025
Merged

Make snowdodgeball better on different screen sizes#225
Jezzamonn merged 3 commits into
google:mainfrom
saranshsaini:reactive-snowdodgeball

Conversation

@saranshsaini

Copy link
Copy Markdown
Collaborator

No description provided.

@speechless-parrot

Copy link
Copy Markdown

new game coming????????? 🔥🔥🔥

@Jezzamonn Jezzamonn left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to approve / merge this for the moment so we can test it more easily

@@ -89,7 +105,38 @@ export class Game {


resize() {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, this is a little janky... I think all these changes can be done with css actually -- most of these lines just set CSS classes to values that eventually are just CSS constants.

Generally we should also not style the page too differently if it has touch controls or not -- some laptops have touch screens, and ipads are relatively large and don't need separate styling compared to phones.

When I tested this on a phone UI using the Chrome dev tools, I noticed the health bar is cropped of the screen:

Image

and I also noticed that the end screens looks a little off with the phone UI

Image

I could take a look tomorrow and see what it might look like with CSS changes?

@Jezzamonn
Jezzamonn merged commit 3ba97c8 into google:main Dec 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants