Skip to content

Conversation

@Talv
Copy link
Contributor

@Talv Talv commented Aug 19, 2019

New field called trophy_id was added to initdata.
Besides that, nothing else was changed in s2protocol.

https://github.com/Blizzard/s2protocol/blob/3ba4fcbef627b952e183eccd07e51f8184aa7a31/s2protocol/versions/protocol75689.py#L96

diff -U1 protocol75025.py protocol75689.py
--- protocol75025.py
+++ protocol75689.py
@@ -95,3 +95,3 @@
     ('_array',[(0,17),67]),  #68
-    ('_struct',[[('m_control',10,-26),('m_userId',60,-25),('m_teamId',1,-24),('m_colorPref',62,-23),('m_racePref',44,-22),('m_difficulty',3,-21),('m_aiBuild',10,-20),('m_handicap',0,-19),('m_observe',24,-18),('m_logoIndex',6,-17),('m_hero',46,-16),('m_skin',46,-15),('m_mount',46,-14),('m_artifacts',63,-13),('m_workingSetSlotId',25,-12),('m_rewards',64,-11),('m_toonHandle',20,-10),('m_licenses',65,-9),('m_tandemLeaderId',60,-8),('m_commander',46,-7),('m_commanderLevel',6,-6),('m_hasSilencePenalty',13,-5),('m_tandemId',60,-4),('m_commanderMasteryLevel',6,-3),('m_commanderMasteryTalents',66,-2),('m_rewardOverrides',68,-1)]]),  #69
+    ('_struct',[[('m_control',10,-27),('m_userId',60,-26),('m_teamId',1,-25),('m_colorPref',62,-24),('m_racePref',44,-23),('m_difficulty',3,-22),('m_aiBuild',10,-21),('m_handicap',0,-20),('m_observe',24,-19),('m_logoIndex',6,-18),('m_hero',46,-17),('m_skin',46,-16),('m_mount',46,-15),('m_artifacts',63,-14),('m_workingSetSlotId',25,-13),('m_rewards',64,-12),('m_toonHandle',20,-11),('m_licenses',65,-10),('m_tandemLeaderId',60,-9),('m_commander',46,-8),('m_commanderLevel',6,-7),('m_hasSilencePenalty',13,-6),('m_tandemId',60,-5),('m_commanderMasteryLevel',6,-4),('m_commanderMasteryTalents',66,-3),('m_trophyId',6,-2),('m_rewardOverrides',68,-1)]]),  #69
     ('_array',[(0,5),69]),  #70

Copy link
Collaborator

@StoicLoofah StoicLoofah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for taking care of this! I had some users flag for me that new replays weren't parsing correctly and hadn't gotten a chance to look at it yet. I'll tag a new release with this change right after merging this in

@StoicLoofah StoicLoofah merged commit b62c200 into ggtracker:upstream Aug 19, 2019
@StoicLoofah
Copy link
Collaborator

1.4.0 is out and available on pip. Thanks again!

https://github.com/ggtracker/sc2reader/releases/tag/v1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants