Merged
Conversation
Contributor
Author
|
This also adds an important check, i.e.: is this package really pip installable? |
cclauss
reviewed
Jun 26, 2019
StoicLoofah
reviewed
Jun 26, 2019
Collaborator
StoicLoofah
left a comment
StoicLoofah
left a comment
There was a problem hiding this comment.
I'm good with using pytest! If we want that to be our canonical test runner, can you also update our README accordingly? https://github.com/ggtracker/sc2reader#testing
Contributor
Author
|
Oh! A very very good point, I totally missed that! |
Contributor
Author
|
@cclauss and @StoicLoofah can this be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR assumes #82 is already merged. It's diff will be considerably smaller once #82 is merged.
I saw pytest was commented out in
.circleci/config.ymland thought .. well pytest is pretty common nowadays.So I renamed a file from
test_all.pytotest_replays.pyand commented pytest in.