Fallback to backup files for detail loading. #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gusgus01
force-pushed
the
AnonymizedReplayWorkaround
branch
from
f3c2df8 to
48df941
Compare
StoicLoofah
requested changes
Nov 25, 2018
|
Thanks for the comments! Really helps to have someone look over the changes. |
Anonymized replays are missing the main replay.initData and replay.details files, this will fallback to the backup versions. Add a new print statement case to the GameEvent base to cover when just the player.name is missing.
Gusgus01
force-pushed
the
AnonymizedReplayWorkaround
branch
from
48df941 to
3aa603c
Compare
|
I agreed with all your requested changes and I think I made them all. (Whoops, I force-pushed to my branch to maintain the single commit and that makes it not quite possible to view the old code outside of the preview windows above) I attempted to capture the logic in a test (test_game_event_string), then added the new case. Assuming I captured the logic correctly, it looks like I made the changes correctly. I also thought about using a replay and an anonymized replay, but I couldn't find a "Global" example in my replays, so I went with the mock route to hit each branch of logic to make sure it stayed the same. |
StoicLoofah
approved these changes
Nov 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anonymized replays are missing the main replay.initData and
replay.details files, this will fallback to the backup versions.
Add a new print statement case to the GameEvent base to cover
when just the player.name is missing.
Used a replay called out in #61 to test.