Skip to content

Conversation

cclauss
Copy link
Collaborator

@cclauss cclauss commented Oct 7, 2018

No description provided.

@StoicLoofah
Copy link
Collaborator

Cool! Looks good to me.

Question regarding compatibility: is it common for libraries just to test on the latest python 3.x version, or should we be testing all versions historically as well to make sure that they still work?

Also, since we're tweaking versions, can you also update references to versions here as well? we should display support for versions that we are actually testing

"Programming Language :: Python :: 3.2",

https://github.com/ggtracker/sc2reader/blob/95e59b0e3170bb4baf5fa34da9fa4c0bb36ffb70/README.rst

Thanks!

@cclauss
Copy link
Collaborator Author

cclauss commented Oct 8, 2018

I do not think we have to exhaustively test on all versions of Python unless/until we have an issue that says that we have a compatibility problem.

@StoicLoofah
Copy link
Collaborator

Works for me. I updated the GitHub settings to reference the new job names for the status checks. Thanks!

@StoicLoofah StoicLoofah merged commit 7c00c4a into ggtracker:upstream Oct 8, 2018
@cclauss cclauss deleted the patch-3 branch October 8, 2018 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants