Skip to content

#63 cast players in TrackerEvent.__str__ #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 4, 2018
Merged

#63 cast players in TrackerEvent.__str__ #64

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
59987e9
#63 cast players in TrackerEvent.__str__
StoicLoofah Jul 26, 2018
fdb913f
#63 cast players in TrackerEvent.__str__
StoicLoofah Jul 26, 2018
5cdfad1
Add test for print functionality.
Gusgus01 Oct 31, 2018
a66278d
Merge pull request #3 from Gusgus01/63-trackerevent_str_error
StoicLoofah Nov 1, 2018
8c90728
Fix Python 2 issues with test_event_print.
Gusgus01 Nov 2, 2018
f16dddd
Merge pull request #4 from Gusgus01/63-trackerevent_str_error
StoicLoofah Nov 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix Python 2 issues with test_event_print. 
Logic issue with conditional import.
StringIO.StringIO does not support usage of the with keyword.
  • Loading branch information
@Gusgus01
Gusgus01 committed Nov 2, 2018
commit 8c9072873dadbaae4f78c64aa86349e2ea57addb
16 changes: 8 additions & 8 deletions test_replays/test_all.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@
import unittest
# StringIO was changed in python 3
try:
from io import StringIO
except ImportError:
from StringIO import StringIO
except ImportError:
from io import StringIO

import sc2reader
from sc2reader.exceptions import CorruptTrackerFileError
Expand Down Expand Up @@ -589,12 +589,12 @@ def test_65895(self):

def test_event_print(self):
replay = sc2reader.load_replay("test_replays/lotv/lotv1.SC2Replay")
with StringIO() as capturedOutput:
sys.stdout = capturedOutput
for event in replay.events:
print(event)
self.assertIn("PlayerLeaveEvent", capturedOutput.getvalue())
sys.stdout = sys.__stdout__
sys.stdout = capturedOutput = StringIO()
Copy link
Collaborator

@cclauss cclauss Nov 4, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original with open() as form is safer in the face of exceptions... Was there a reason to move away from that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StringIO.StringIO does not implement exit() I believe and can not be used with with() in python2. io.StringIO does and is what is being used in Python3 so could be used with with().

for event in replay.events:
print(event)
self.assertIn("PlayerLeaveEvent", capturedOutput.getvalue())
sys.stdout = sys.__stdout__
capturedOutput.close()


class TestGameEngine(unittest.TestCase):
Expand Down