Early detection of events without a player #62
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 19, 2018 08:03
There are a class of issues like ggtracker#61 where __event.player is None__ so this PR tries to detect that condition higher in the call stack.
|
Thanks for taking a shot at this! Seems like a reasonable check to have, but see #61 for the rougher underlying issue here. Have you seen this same problem in other cases that need to be addressed? My concern with merging this change in on its own will cover up issues (even if it is supposed to be included in the output) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a class of issues like #61 where event.player is None so this PR should print the event in the stacktrace.