Skip to content

fix map_creep_spread test in python3 #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2018
Merged

fix map_creep_spread test in python3 #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3380a2e
fix map_creep_spread test in python3
StoicLoofah Apr 29, 2018
a5bfd43
commenting a minor inconsistency found in unit tests
StoicLoofah May 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sc2reader/engine/plugins/creeptracker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,12 @@ def handleEndGame(self, event, replay):
if player.play_race[0] == 'Z':
self.creepTracker.reduce_cgu_per_minute(player.pid)
player.creep_spread_by_minute = self.creepTracker.get_creep_spread_area(player.pid)
# note that player.max_creep_spread may be a tuple or an int
if player.creep_spread_by_minute:
player.max_creep_spread = max(player.creep_spread_by_minute.items(),key=lambda x:x[1])
else:
## Else statement is for players with no creep spread(ie: not Zerg)
player.max_creep_spread =0
player.max_creep_spread = 0
except Exception as e:
print("Whoa! {}".format(e))
pass
Expand Down
2 changes: 1 addition & 1 deletion test_replays/test_all.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ def test_lotv_creepTracker(self):

for player_id in replay.player:
if replay.player[player_id].play_race == "Zerg":
assert replay.player[player_id].max_creep_spread >0
assert replay.player[player_id].max_creep_spread != 0
assert replay.player[player_id].creep_spread_by_minute

def test_lotv_map(self):
Expand Down