StringIO—> BytesIO when converting map to PIL image #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the motivation and context for this change? I admittedly am not very familiar with this plugin or what the implications are |
|
#43 (comment) is the Python 3-only exception that this PR hopes to correct. It is caused by the difference between string and bytes data. In Python 2 there is no distinction between bytes and strings so they can be used interchangeably. However Python 3 makes a clear distinction so when dealing with a map that we want to convert into a PIL image, we must use bytes instead of a string. This fix clears the exception and let's us focus on the failing tests. |
|
sorry for the delay getting this in. Thanks for debugging and addressing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.