Python 3 scoping rules: human.pids --> human_pids #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3 has more restrictive scoping rules that Python 2 so a variable created inside of a list comprehension is not available outside of that list comprehension. flake8 testing of https://github.com/ggtracker/sc2reader on Python 3.6.3 $ __flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics__ ``` ./sc2reader/scripts/sc2parse.py:48:25: F821 undefined name 'human' human.pids = set([human.pid for human in replay.humans]) ^ ./sc2reader/scripts/sc2parse.py:52:28: F821 undefined name 'human' if human.pids != event_pids: ^ ./sc2reader/scripts/sc2parse.py:53:109: F821 undefined name 'human' print('Event Pid problem! pids={pids} but event pids={event_pids}'.format(pids=human.pids, event_pids=event_pids)) ^ 3 F821 undefined name 'human' 3 ``` This PR creates a new __human_pids__ to hold the set of all __replay.humans.pids__ instead of modifying the pid of the last human in that list.
|
These fixes are also incorporated in #47 |
|
Since these changes are in #47, can we close this PR now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3 has more restrictive scoping rules that Python 2 so a variable created inside of a list comprehension is not available outside of that list comprehension.
flake8 testing of https://github.com/ggtracker/sc2reader on Python 3.6.3
$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics
This PR creates a new human_pids to hold the set of all replay.humans.pids instead of modifying the pid of the last human in that list.