Merged
Conversation
StoicLoofah
commented
Apr 6, 2018
| :param dict attribute_data: The attribute data associated with this player | ||
| """ | ||
| def __init__(self, pid, detail_data, attribute_data): | ||
| def __init__(self, pid, slot_data, detail_data, attribute_data): |
Collaborator
Author
There was a problem hiding this comment.
have to pass slot_data through to Player because that's where the commander name is
| player_id += 1 | ||
|
|
||
| elif slot_data['control'] == 3: | ||
| elif slot_data['control'] == 3 and detail_id < len(details['players']): |
Collaborator
Author
There was a problem hiding this comment.
to be honest, I'm not really sure why this was necessary
Member
|
sweeeeeet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if anyone else is actively watching this repo for changes, but I added basic co-op support!
Most of the changes here are just addressing errors from co-op. I'll comment through on those.
I also added the commander to
Playerso you can check that.Note that
replay.cooperative == 0for these replays. I filed an issue for it Blizzard/s2protocol#69 In the meantime, checking for a commander being set is the best we haveI might merge sometime on my own if no one reviews it, but it would be great if someone could take a look