Skip to content

Build 59587 support #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsjoerg merged 2 commits into from
Nov 20, 2017
Merged

Build 59587 support #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8ed752
add support for build 59587
StoicLoofah Nov 20, 2017
7d32fd4
added a test
StoicLoofah Nov 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sc2reader/readers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ def __call__(self, data, replay):
observers=data.read_bits(2),
user_difficulty=data.read_bits(2),
client_debug_flags=data.read_uint64() if replay.base_build >= 22612 else None,
build_coach_enabled=data.read_bool() if replay.base_build >= 59587 else None,
),
game_speed=data.read_bits(3),
game_type=data.read_bits(3),
Expand Down
Binary file added test_replays/4.0.0.59587/1.SC2Replay
View file
Open in desktop
Binary file not shown.
13 changes: 10 additions & 3 deletions test_replays/test_all.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,14 +537,14 @@ def test_312(self):
factory = sc2reader.factories.SC2Factory()
replay =factory.load_replay(replayfilename,load_level=0)
replay =factory.load_replay(replayfilename,load_level=1)

def test_316(self):
for replayfilename in [
"test_replays/3.16/AbyssalReef.SC2Replay",
]:
factory = sc2reader.factories.SC2Factory()
replay =factory.load_replay(replayfilename)

def test_54518(self):
for replayfilename in [
"test_replays/3.14.0.54518/1.SC2Replay",
Expand All @@ -553,7 +553,14 @@ def test_54518(self):
]:
factory = sc2reader.factories.SC2Factory()
replay =factory.load_replay(replayfilename)


def test_59587(self):
for replayfilename in [
"test_replays/4.0.0.59587/1.SC2Replay",
]:
factory = sc2reader.factories.SC2Factory()
replay = factory.load_replay(replayfilename)


class TestGameEngine(unittest.TestCase):
class TestEvent(object):
Expand Down