Skip to content

Conversation

@cclauss
Copy link
Collaborator

@cclauss cclauss commented Aug 22, 2017

No description provided.

@dsjoerg dsjoerg merged commit c0beb4e into ggtracker:upstream Aug 22, 2017
@cclauss cclauss deleted the patch-3 branch August 22, 2017 21:26
@cclauss
Copy link
Collaborator Author

cclauss commented Aug 22, 2017

What is with the Circle CI processes? Do they ever execute? Do they give you output? Or is there a misconfiguration in the circle.yml file?

@cclauss
Copy link
Collaborator Author

cclauss commented Aug 22, 2017

Status looks good https://status.circleci.com/ but none of these CI builds ever run.

@GraylinKim
Copy link
Member

I'm curious why you switched to CircleCI @dsjoerg.

@cclauss you might try a PR that fixes the circle.yml file which it seems has changed significantly with version 2. http://circleci.com/docs/2.0/configuration-reference/

@ghost
Copy link

ghost commented Aug 23, 2017

@GraylinKim CircleCI can be actually better than travis - it has better free plan (4 concurrent builds for open-source projects).
And also there's a free plan for closed-source(!) projects

@dsjoerg
Copy link
Member

dsjoerg commented Aug 23, 2017

@GraylinKim I forget why I switched to CircleCI, I vaguely remember there was something I needed Travis to do but I couldnt get it to do what I wanted and it was easier to switch.

@dsjoerg
Copy link
Member

dsjoerg commented Aug 23, 2017

@cclauss I had CircleCI set up to run tests on every commit to the upstream branch (which is our primary branch). However I did not have it set to run on PRs. I switched that setting just now, so from now on it will run tests on PRs as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants