Add support for build version 53644 replays#26
Conversation
sc2reader/data/ability_lookup.csv
Outdated
| BanelingNestResearch,EvolveCentrifugalHooks,EvolveTunnelingJaws,,,,,,,,,,,,,,,,,,,,,,,,,,,,,CancelBanelingNestResearch, | ||
| BansheeCloak,CloakBanshee,DecloakBanshee,,,,,,,,,,,,,,,,,,,,,,,,,,,,,, | ||
| BanelingNestResearch,ResearchCentrificalHooks,EvolveTunnelingJaws,,,,,,,,,,,,,,,,,,,,,,,,,,,,,CancelBanelingNestResearch, | ||
| BansheeCloak,On,Off,,,,,,,,,,,,,,,,,,,,,,,,,,,,,, |
There was a problem hiding this comment.
Overwritten old command name with command id from data export
sc2reader/data/ability_lookup.csv
Outdated
| AttackWarpPrism,AttackWarpPrism,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,, | ||
| BanelingNestResearch,EvolveCentrifugalHooks,EvolveTunnelingJaws,,,,,,,,,,,,,,,,,,,,,,,,,,,,,CancelBanelingNestResearch, | ||
| BansheeCloak,CloakBanshee,DecloakBanshee,,,,,,,,,,,,,,,,,,,,,,,,,,,,,, | ||
| BanelingNestResearch,ResearchCentrificalHooks,EvolveTunnelingJaws,,,,,,,,,,,,,,,,,,,,,,,,,,,,,CancelBanelingNestResearch, |
There was a problem hiding this comment.
Overwritten old command name with 'research' prefix rather than 'evolve' prefix. This reflects a change in the structure of the balance data export.
|
As long as these changes don't break GGTracker, I'll take them. This weekend or tonight I'll work the changes through the tests and see how they do. |
|
Noticed some related open issues: From the discussion in GraylinKim#88, it seems like preferring ability names that match to Blizzard's internal names for them (as I have implemented) was the preferred option to migrate towards. |
|
Oooh actually this will cause a problem for ggtracker. The existing unit tests didnt catch this problem, I'm worried now about the best way to test/validate this before pushing it into production and fielding complaints from users... From my perspective the easiest way forward would be to not change the name of any of the existing commands that were previously correct. @frugs would that work for you? |
|
@dsjoerg I should be able to modify the generation script such that old names are preserved. I'll update this pull request with the newly generated files. If they past testing, I'll submit a new pull request for the modifications I had to make to the generation script. |
|
|
|
Thanks @frugs !! Looks good to me. I'm going to push this into GGTracker production and we'll see if it causes problems. (The unit tests were already passing, so if there's still a problem, prod is the way to find it now) |
@dsjoerg Please look over some of the changes made to
abilities_lookup.csv. I have overwritten some of the previous command names with ones based on the command ids in the balance data export. This provides better overall naming consistency, at the cost of potentially breaking clients that are dependent on the pre-existing names.However, given the command names have been broken for several months (in fact, quite possibly over a year) already, I doubt that any such clients actually exist.
I will add PR comments on some of the changed lines to make it easier for you to locate them.