Extended build data generation script to also generate ability_lookup…#23
Merged
dsjoerg merged 1 commit intoggtracker:upstreamfrom Jun 9, 2017
Merged
Extended build data generation script to also generate ability_lookup…#23dsjoerg merged 1 commit intoggtracker:upstreamfrom
dsjoerg merged 1 commit intoggtracker:upstreamfrom
Conversation
….csv and unit_lookup.csv
Member
|
Hey @frugs does your "Note that..." comment in your PR message belong in the HOWTO? |
Contributor
Author
|
It does. My intention was to update the HOWTO with some detailed steps once everything is in place in a final PR once the new balance data generation pipeline was completed. I had decided to split up my changes across several pull requests in order to make them easier to review, but would you prefer I submit it all my changes at once? |
Member
|
So far your changes haven't modified existing code but have been strictly adding new code, so I haven't been reviewing carefully. And so multiple PRs are fine, as long as we don't forget to change the HOWTO at the end :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
….csv and unit_lookup.csv
Note that the generated lookup csvs are missing information not present in the provided balance data, and will need to be merged with older lookup csvs rather than simply overwriting them.