Skip to content

Conversation

frugs
Copy link
Contributor

@frugs frugs commented Jun 9, 2017

….csv and unit_lookup.csv

Note that the generated lookup csvs are missing information not present in the provided balance data, and will need to be merged with older lookup csvs rather than simply overwriting them.

@dsjoerg
Copy link
Member

dsjoerg commented Jun 9, 2017

Hey @frugs does your "Note that..." comment in your PR message belong in the HOWTO?

@frugs
Copy link
Contributor Author

frugs commented Jun 9, 2017

It does. My intention was to update the HOWTO with some detailed steps once everything is in place in a final PR once the new balance data generation pipeline was completed.

I had decided to split up my changes across several pull requests in order to make them easier to review, but would you prefer I submit it all my changes at once?

@dsjoerg
Copy link
Member

dsjoerg commented Jun 9, 2017

So far your changes haven't modified existing code but have been strictly adding new code, so I haven't been reviewing carefully. And so multiple PRs are fine, as long as we don't forget to change the HOWTO at the end :)

@dsjoerg dsjoerg merged commit 7291d99 into ggtracker:upstream Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants