Fix utcfromtimestamp deprecation warnings#215
Merged
StoicLoofah merged 6 commits intoggtracker:upstreamfrom Jan 5, 2026
Merged
Fix utcfromtimestamp deprecation warnings#215StoicLoofah merged 6 commits intoggtracker:upstreamfrom
StoicLoofah merged 6 commits intoggtracker:upstreamfrom
Conversation
Contributor
Author
|
Test is failing due to a timestamp comparison. Prior behavior of utcfromtimestamp was to generate a naive datetime, now datetimes are aware. Is it desired to have the prior behavior? |
Collaborator
I think the new behavior is better. Can you update the test to match the new behavior? Thanks for jumping on this so quickly! |
StoicLoofah
approved these changes
Jan 5, 2026
Collaborator
StoicLoofah
left a comment
StoicLoofah
left a comment
There was a problem hiding this comment.
Good stuff. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #214