Skip to content

Add pre-commit#211

Merged
StoicLoofah merged 3 commits into
ggtracker:upstreamfrom
cclauss:pre-commit
Jan 1, 2026
Merged

Add pre-commit#211
StoicLoofah merged 3 commits into
ggtracker:upstreamfrom
cclauss:pre-commit

Conversation

@cclauss
Copy link
Copy Markdown
Collaborator

@cclauss cclauss commented Sep 26, 2025

https://pre-commit.com

% pre-commit run --all-files

check for added large files..............................................Passed
check python ast.........................................................Passed
check for case conflicts.................................................Passed
check docstring is first.................................................Passed
check json...............................................................Passed
check for merge conflicts................................................Passed
check that scripts with shebangs are executable..........................Passed
check for broken symlinks............................(no files to check)Skipped
check toml...............................................................Passed
check vcs permalinks.....................................................Passed
check xml............................................(no files to check)Skipped
check yaml...............................................................Passed
debug statements (python)................................................Passed
detect destroyed symlinks................................................Passed
detect private key.......................................................Passed
fix end of files.........................................................Passed
file contents sorter.................................(no files to check)Skipped
fix utf-8 byte order marker..............................................Passed
forbid new submodules................................(no files to check)Skipped
forbid submodules....................................(no files to check)Skipped
fix requirements.txt.....................................................Passed
sort simple yaml files...............................(no files to check)Skipped
trim trailing whitespace.................................................Passed
auto-walrus..............................................................Passed
codespell................................................................Passed
ruff check...............................................................Passed
pyproject-fmt............................................................Passed
Validate pyproject.toml..................................................Passed

Please remove Required test ci/circleci: Python3 below because that CircleCI job has been renamed topytest.

Comment thread sc2reader/decoders.py

# If we've got a byte in progress use it first
if bit_shift != 0:
if (bit_shift := self._bit_shift) != 0:
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't realize that the walrus operator was recommended these days. I personally don't have strong feelings on it, but I know others who do haha

Comment thread .pre-commit-config.yaml
- id: sort-simple-yaml
- id: trailing-whitespace

- repo: https://github.com/MarcoGorelli/auto-walrus
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah got it

@StoicLoofah StoicLoofah merged commit 3559fe4 into ggtracker:upstream Jan 1, 2026
3 checks passed
@cclauss cclauss deleted the pre-commit branch January 1, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants