Skip to content

Conversation

@cclauss
Copy link
Collaborator

@cclauss cclauss commented Apr 27, 2025

Fixes #208

Showed that two utils.py files were conflicting with each other and making imports fail.

  • sc2reader/utils.py
  • sc2reader/scripts/utils.py

Let's remove the latter because it is only used in examples/sc2autosave.py and not in scripts or any other directory.

Copy link
Collaborator

@StoicLoofah StoicLoofah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@StoicLoofah StoicLoofah merged commit 609e1df into ggtracker:upstream Apr 28, 2025
2 checks passed
@cclauss cclauss deleted the fix_examples branch April 28, 2025 05:24
@cclauss cclauss changed the title Fix examples/sc2autosave.py my moving sc2reader.scripts.utils.Formatter Fix examples/sc2autosave.py by moving sc2reader.scripts.utils.Formatter Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scripts not contained in the module

2 participants