Update ruff settings and fix rules C417 and UP032 #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
force-pushed
the
modernize-ruff
branch
from
955504a to
6b7f782
Compare
StoicLoofah
approved these changes
Jan 22, 2025
| @@ -13,9 +13,9 @@ keywords = [ | |||
| "sc2", | |||
| "starcraft 2", | |||
| ] | |||
| license = {text = "MIT"} | |||
| authors = [{name = "Kevin Leung", email = "[email protected]"}] | |||
| requires-python = ">=3.7" | |||
There was a problem hiding this comment.
Are there specific changes that dropped support for python 3.7 and python 3.8, or is this just tidying up because those versions are end-of-life?
There was a problem hiding this comment.
Removing end of life Python encourages users to avoid relying on unsafe software.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
%
ruff check --select=C417 --fix --unsafe-fixes%
ruff check --select=UP032 --fix%
validate-pyproject pyproject.toml%
pyproject-fmt pyproject.toml