Skip to content

Conversation

Andrene
Copy link
Contributor

@Andrene Andrene commented May 29, 2024

Adds the DialogControlEvent game event type.

This is for interactions with dialogs ingame and allows for some neat data collection as it looks to generate an event when a trigger modifys a dialog field aswell.

Control ID seems for the most part useless
Event types seem to match with the ones listed here https://mapster.talv.space/galaxy/reference/preset-control-event-type
Event data contains what a dialog text box was changedto, if a check box checked or unchecked, etc

@Andrene
Copy link
Contributor Author

Andrene commented May 29, 2024

Style check is failing on a function since it thinks "assertIn" is a typo :)
self.assertIn("PlayerLeaveEvent", capturedOutput.getvalue())

@cclauss
Copy link
Collaborator

cclauss commented May 30, 2024

Add assertin (all lowercase) to this line.

- run: codespell -L queenland,uint

Copy link
Collaborator

@StoicLoofah StoicLoofah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind running black so it can clean up the formatting?

I can also pop it on top if it's tricky for you to get that in

@Andrene
Copy link
Contributor Author

Andrene commented May 30, 2024

Yep, it was a wee agressive in readers.py

@StoicLoofah StoicLoofah merged commit 46629e5 into ggtracker:upstream May 30, 2024
@StoicLoofah
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants