PEP 621: Migrate from setup.py to pyproject.toml#193
Merged
Conversation
StoicLoofah
approved these changes
Sep 23, 2023
Collaborator
StoicLoofah
left a comment
There was a problem hiding this comment.
Looks like a pretty faithful migration. Thanks for the legwork and explanation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How
Migrate
setup.pytosetup.cfgusing setuptools-py2cfg plus manual modifications. Use setup-cfg-fmt to format the results.Migrate settings from
setup.cfgintopyproject.tomlusing ini2toml to do the file conversion and running pyproject-fmt and then validate-pyproject to validate the results.Why
https://setuptools.pypa.io/en/latest/userguide/quickstart.html#basic-use
From
validate-pyprojectREADME: