Skip to content

Feat: add mmr for Players and Observers #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StoicLoofah merged 3 commits into from
Sep 1, 2023
Merged

Feat: add mmr for Players and Observers #190

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce38298
feat: add mmr for User class
NumberPigeon Aug 30, 2023
77a82cb
refactor: cleaner code
NumberPigeon Aug 30, 2023
50a137e
doc: meaningful tmp var name, while keeping the attribute's name simple
NumberPigeon Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: cleaner code 
Co-authored-by: Christian Clauss <[email protected]>
  • Loading branch information
@NumberPigeon @cclauss
NumberPigeon and cclauss authored Aug 30, 2023
commit 77a82cb77f4a2515f6ba0160f7c982146a993d06
10 changes: 2 additions & 8 deletions sc2reader/objects.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,14 +291,8 @@ def __init__(self, uid, init_data):
#: 2. The user has a None value for their 'scaled_rating' key, or
#: 3. The user has a negative rating, often -36400.
#: For ease of use, this property will return None in both cases.
if (
"scaled_rating" in init_data
and init_data["scaled_rating"] is not None
and init_data["scaled_rating"] > 0
):
self.mmr = init_data["scaled_rating"]
else:
self.mmr = None
mmr = int(init_data.get("scaled_rating") or 0)
self.mmr = mmr if mmr > 0 else None

@property
def url(self):
Expand Down