Identify all ControlGroupEvent update_types #187
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These new definitions are based on a few experiments (done in this replay). If anyone ever wants to get the selection plugin working well again, this change (and likely a few more) are necessary. The context and apm plugins could be impacted too, but I don't understand those well.
In each of the experiments below, I issued a single command in game. That single command results in many in game events.
The tables below show both the old event name (before this PR) and the new event name (after this PR).
Experiment 1
Before Command: Control Groups 1 and 2 consist exactly of all 12 starting probes. All other control groups empty.
Command issued: With all 12 probes selected, steal and create group 3 (alt + 3)
After Command: Controls Group 3 consists exactly of all 12 starting probes. All other controls groups empty.
Experiment 2
Before Command: Control Groups 1, 2, 3 consist exactly of all 12 starting probes. All other control groups empty.
Command issued: With all 12 probes selected, steal and add to group 4 (alt + shift + 4)
After Command: Controls Group 4 consists exactly of all 12 starting probes. All other controls groups empty.
Experiment 3
Before Command: Control Groups 1, 2, 3, 4 consist exactly of all 12 starting probes. All other control groups empty.
Command issued: With 11 of the 12 probes selected, steal and create group 5 (alt + 5)
After Command: Control Groups 1, 2, 3, 4 consist exactly of the same single probe. Control group 5 has 11 probes.
Experiment 4
Before Command: Control Groups 1, 2, 3, 4 consist exactly of the same single probe. Control group 5 has 11 probes. All other control groups empty.
Command issued: With the single probe from control groups 1,2,3,4 selected, steal and add to group 5 (alt + shift + 5)
After Command: Control group 5 has 12 probes. All other control groups empty.