Skip to content

Conversation

dlithio
Copy link
Contributor

@dlithio dlithio commented Aug 17, 2023

These new definitions are based on a few experiments (done in this replay). If anyone ever wants to get the selection plugin working well again, this change (and likely a few more) are necessary. The context and apm plugins could be impacted too, but I don't understand those well.

In each of the experiments below, I issued a single command in game. That single command results in many in game events.

The tables below show both the old event name (before this PR) and the new event name (after this PR).

Experiment 1

Before Command: Control Groups 1 and 2 consist exactly of all 12 starting probes. All other control groups empty.
Command issued: With all 12 probes selected, steal and create group 3 (alt + 3)
After Command: Controls Group 3 consists exactly of all 12 starting probes. All other controls groups empty.

old name new name frame control group update type mask type len new unit ids
ControlGroupEvent SetControlGroupEvent 288 3 4 None
ControlGroupEvent DeleteControlGroupEvent 288 1 3 None
ControlGroupEvent DeleteControlGroupEvent 288 2 3 None

Experiment 2

Before Command: Control Groups 1, 2, 3 consist exactly of all 12 starting probes. All other control groups empty.
Command issued: With all 12 probes selected, steal and add to group 4 (alt + shift + 4)
After Command: Controls Group 4 consists exactly of all 12 starting probes. All other controls groups empty.

old name new name frame control group update type mask type len new unit ids
ControlGroupEvent AddToControlGroupEvent 527 4 5 None
ControlGroupEvent DeleteControlGroupEvent 527 1 3 None
ControlGroupEvent DeleteControlGroupEvent 527 2 3 None
ControlGroupEvent DeleteControlGroupEvent 527 3 3 None

Experiment 3

Before Command: Control Groups 1, 2, 3, 4 consist exactly of all 12 starting probes. All other control groups empty.
Command issued: With 11 of the 12 probes selected, steal and create group 5 (alt + 5)
After Command: Control Groups 1, 2, 3, 4 consist exactly of the same single probe. Control group 5 has 11 probes.

old name new name frame control group update type mask type len new unit ids
ControlGroupEvent SetControlGroupEvent 1221 5 4 None nan
GetControlGroupEvent GetControlGroupEvent 1221 1 2 None nan
SelectionEvent SelectionEvent 1221 10 nan ZeroIndices 0
SetControlGroupEvent SetControlGroupEvent 1221 1 0 None nan
SelectionEvent SelectionEvent 1221 10 nan ZeroIndices 11
GetControlGroupEvent GetControlGroupEvent 1221 2 2 None nan
SelectionEvent SelectionEvent 1221 10 nan ZeroIndices 0
SetControlGroupEvent SetControlGroupEvent 1221 2 0 None nan
SelectionEvent SelectionEvent 1221 10 nan ZeroIndices 11
GetControlGroupEvent GetControlGroupEvent 1221 3 2 None nan
SelectionEvent SelectionEvent 1221 10 nan ZeroIndices 0
SetControlGroupEvent SetControlGroupEvent 1221 3 0 None nan
SelectionEvent SelectionEvent 1221 10 nan ZeroIndices 11
GetControlGroupEvent GetControlGroupEvent 1221 4 2 None nan
SelectionEvent SelectionEvent 1221 10 nan ZeroIndices 0
SetControlGroupEvent SetControlGroupEvent 1221 4 0 None nan
SelectionEvent SelectionEvent 1222 10 nan ZeroIndices 11

Experiment 4

Before Command: Control Groups 1, 2, 3, 4 consist exactly of the same single probe. Control group 5 has 11 probes. All other control groups empty.
Command issued: With the single probe from control groups 1,2,3,4 selected, steal and add to group 5 (alt + shift + 5)
After Command: Control group 5 has 12 probes. All other control groups empty.

old name new name frame control group update type mask type len new unit ids
ControlGroupEvent AddToControlGroupEvent 1460 5 5 None
ControlGroupEvent DeleteControlGroupEvent 1460 1 3 None
ControlGroupEvent DeleteControlGroupEvent 1460 2 3 None
ControlGroupEvent DeleteControlGroupEvent 1460 3 3 None
ControlGroupEvent DeleteControlGroupEvent 1460 4 3 None

Copy link
Collaborator

@StoicLoofah StoicLoofah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the homework here. Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants