Skip to content

add balance data for 89720 #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 20, 2023
Merged

add balance data for 89720 #181

merged 3 commits into from
Mar 20, 2023

Conversation

HADB
Copy link
Contributor

@HADB HADB commented Feb 13, 2023 •
edited
Loading

@cclauss
Copy link
Collaborator

cclauss commented Feb 13, 2023 •
edited
Loading

To fix the failing lint tests, please
% python3 -m pip install --upgrade black
% black .

@StoicLoofah
Copy link
Collaborator

Changes conceptually look good. As mentioned, if you could clean up the black linting issues, we should be able to merge this!

cclauss
cclauss approved these changes Feb 14, 2023
View reviewed changes
Copy link
Collaborator

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

StoicLoofah
StoicLoofah approved these changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@StoicLoofah StoicLoofah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THanks!

@StoicLoofah StoicLoofah merged commit b137910 into ggtracker:upstream Mar 20, 2023
@HADB HADB changed the title add banalce data for 89720 add balance data for 89720 Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StoicLoofah StoicLoofah StoicLoofah approved these changes

+1 more reviewer

@cclauss cclauss cclauss approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing ability <number> from Build, Unknown attribute id: <number> - Error
3 participants
@HADB @cclauss @StoicLoofah