Skip to content

Remove encoding option from JSON script. #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Remove encoding option from JSON script. #178

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ab2e86
Remove encoding option from JSON script.
manuelseeger Jan 8, 2023
8d7c5af
Blackout
manuelseeger Jan 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove encoding option from JSON script. 
Python3 deprecates encoding options in JSON.dumps and defaults to UTF8.
  • Loading branch information
@manuelseeger
manuelseeger committed Jan 8, 2023
commit 3ab2e86278b03ebce2d7e174776cb3ce14336c68
11 changes: 2 additions & 9 deletions sc2reader/scripts/sc2json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,6 @@ def main():
default=None,
help="The per-line indent to use when printing a human readable json string",
)
parser.add_argument(
"--encoding",
"-e",
type=str,
default="UTF-8",
help="The character encoding use..",
)
parser.add_argument(
"path",
metavar="path",
Expand All @@ -34,8 +27,8 @@ def main():
factory = sc2reader.factories.SC2Factory()
try:
factory.register_plugin(
"Replay", toJSON(encoding=args.encoding, indent=args.indent)
) # legacy Python
"Replay", toJSON(indent=args.indent)
)
except TypeError:
factory.register_plugin("Replay", toJSON(indent=args.indent))
replay_json = factory.load_replay(args.path[0])
Expand Down