Skip to content

Conversation

cclauss
Copy link
Collaborator

@cclauss cclauss commented May 25, 2022

Remove support for all end-of-life versions of Python so that we now support current versions of Python.

This was done by running pyupgrade --py37-plus **/*.py which removes 168 lines of unnecessary code.

Python f-strings are easier to read and are faster: https://www.scivision.dev/python-f-string-speed

The CircleCI Python2 job was removed so a maintainer should remove Python2 as a required job below.

Copy link
Collaborator

@StoicLoofah StoicLoofah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glanced through this, but to be honest, I trust the tests more than my eye. Also always good to have automated solutions

Thanks for the work here!

@StoicLoofah StoicLoofah merged commit c17bd35 into ggtracker:upstream Jun 12, 2022
@cclauss cclauss deleted the drop-legacy-python branch June 12, 2022 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants