force gameheart to exit if game is played in LotV#171
Merged
StoicLoofah merged 1 commit intoggtracker:upstreamfrom May 5, 2022
Andrene:upstream
Merged
force gameheart to exit if game is played in LotV#171StoicLoofah merged 1 commit intoggtracker:upstreamfrom Andrene:upstream
StoicLoofah merged 1 commit intoggtracker:upstreamfrom
Andrene:upstream
Conversation
StoicLoofah
approved these changes
May 5, 2022
Collaborator
|
Thanks for the fix! I'll get a release lined up in a moment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue #170
Tested this and players are correctly noted as players rather than observers post-change.
The only thing with this method is the Void.SC2Mod dependency has to be used by the map to get identified as a LoTV map.
I was going to use base_build to determine if the plugin should exit, but was guessing that if someone were to go and play a HOTS map with gameheart enabled that it would have the current base_build and so wouldn't be parsed by this change even though it should... If you think thats a better method then I can update the pr.
If merged would it be possible to also get a release :)