Added class CommandManagerStateEvent.#162
Merged
StoicLoofah merged 1 commit intoggtracker:upstreamfrom Feb 24, 2022
Merged
Conversation
cclauss
reviewed
Feb 22, 2022
danfulton
force-pushed
the
danfulton/bugfix-117-queued-units
branch
from
ed305ca to
6b562fa
Compare
Contributor
Author
|
Was using an older version of Black, but fixed the linting check. |
danfulton
force-pushed
the
danfulton/bugfix-117-queued-units
branch
from
fecbc44 to
6b562fa
Compare
Contributor
Author
|
Reverting the super() call so the PR passes the Python 2 Circle CI check. I would suggest removing Python 2 check and updating all the Event classes at once to use the newer style if the project really is Python 3 only. |
Collaborator
|
My mistake — thanks for the revert. I opened #163 |
StoicLoofah
approved these changes
Feb 24, 2022
Collaborator
StoicLoofah
left a comment
StoicLoofah
left a comment
There was a problem hiding this comment.
Great addition. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in #117 , repeated CommandEvents were not showing up in the events queue when they occurred. When a CommandEvent is repeated, it is recorded as a CommandManagerStateEvent, presumably to save space. Added a class so these are now available.
Also some minor reformatting from running Black.
Resolves #117