fix black formatting from StyleCheck 625 #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StoicLoofah
commented
Jan 31, 2022
STYLE_GUIDE.rst
Outdated
| @@ -18,10 +22,7 @@ All files should start with the following:: | |||
| All imports should be absolute. | |||
|
|
|||
|
|
|||
| All string formatting sound be done in the following style:: | |||
| All string formatting should be done in the following style:: | |||
There was a problem hiding this comment.
I actually wasn't sure if we should insist on .format or if we should support f-strings
There was a problem hiding this comment.
pyupgrade will autoconvert to f-strings which are faster and easier to read.
https://www.scivision.dev/python-f-string-speed/
cclauss
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the failure from https://app.circleci.com/pipelines/github/ggtracker/sc2reader/56/workflows/26b5f9e8-b09e-4b41-ac18-4dbc023efab1/jobs/625
I noticed this issue cropped up since we haven't specified a
blackversion heresc2reader/.circleci/config.yml
Line 18 in a38e266
What do you guys think about letting it float as is versus specifying a version now that
blackis stable? https://github.com/psf/black/releases/tag/stableI also updated the style guide docs a bit