url_template updates#151
Merged
StoicLoofah merged 5 commits intoggtracker:upstreamfrom Aug 16, 2021
Andrene:upstream
Merged
Conversation
load_map=True should now work on CN and NA out of the box. Updated the other url_templates to use the new blizzard CDN, although I neglected to include CN in them as adding it would be a bit more effort/it seems those were rarely used anyway since no one complained they were broken.
Contributor
Author
|
Well, I'm not sure exactly why the style check failed(or at least it doesn't tell me what to change, and why it doesn't like it.)... The only thing I changed in utils.py was the janky solution to the cn depot problem. Guess I'll figure out a non janky solution. |
cclauss
reviewed
Aug 16, 2021
cclauss
reviewed
Aug 16, 2021
Renamed urlEnd to url_suffix for naming rules/better naming
cclauss
reviewed
Aug 16, 2021
StoicLoofah
reviewed
Aug 16, 2021
Collaborator
StoicLoofah
left a comment
StoicLoofah
left a comment
There was a problem hiding this comment.
Thanks for the fix here! Sorry for the fight against the code formatter, but once those build checks are passing, I would be happy to merge this in!
StoicLoofah
approved these changes
Aug 16, 2021
Collaborator
StoicLoofah
left a comment
StoicLoofah
left a comment
There was a problem hiding this comment.
Looks great. Thanks so much!
Collaborator
|
Let me know if you need a versioned release for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
load_map=True should now work on CN and NA out of the box.
Updated the other url_templates to use the new blizzard CDN, although I neglected to include CN in them as adding it would be a bit more effort/it seems those were rarely used anyway since no one complained they were broken.
See issue #140
Feel free to tell me to change my solution if it is too janky (I know its janky, just not if it too janky)