Skip to content

Fixed depot url template. SC2Reader wasn't working with previous due to blizzard update#139

Merged
StoicLoofah merged 2 commits intoggtracker:upstreamfrom
Andrene:upstream
Jan 14, 2021
Merged

Fixed depot url template. SC2Reader wasn't working with previous due to blizzard update#139
StoicLoofah merged 2 commits intoggtracker:upstreamfrom
Andrene:upstream

Conversation

@Andrene
Copy link
Copy Markdown
Contributor

@Andrene Andrene commented Jan 14, 2021

Blizzard changed the depot url format.
Updated with new format

Blizzard changed the depot url format.
Updated with new format
@cclauss
Copy link
Copy Markdown
Collaborator

cclauss commented Jan 14, 2021

Three quotes...
File "/home/circleci/.local/lib/python3.9/site-packages/sc2reader/utils.py", line 23
E url_template = "https://{0}-s2-depot.classic.blizzard.com/{1}.{2}""

@Andrene
Copy link
Copy Markdown
Contributor Author

Andrene commented Jan 14, 2021

Not sure how that happened, but its removed now, thanks for the heads up!

Copy link
Copy Markdown
Collaborator

@StoicLoofah StoicLoofah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@StoicLoofah StoicLoofah merged commit c2a5407 into ggtracker:upstream Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants