Integrated ResourceTradeEvent and added test#135
Integrated ResourceTradeEvent and added test#135StoicLoofah merged 4 commits intoggtracker:upstreamfrom
Conversation
|
Also make sure to run |
|
#!/bin/bash -eo pipefail would reformat /home/circleci/project/sc2reader/events/game.py |
| self.minerals, self.vespene, self.terrazine, self.custom_resource | ||
| return ( | ||
| self._str_prefix() | ||
| + " requests {0} minerals, {1} gas, {2} terrazine, and {3} custom".format( |
There was a problem hiding this comment.
The {0} {1} {2} {3} thing has not been needed since Python 2.6 unless you want substitutions to land out of order or you want substitutions to repeat.
There was a problem hiding this comment.
This is how it was originally written and how the other classes in this file are written as well. Maybe create a separate issue to change this more broadly?
There was a problem hiding this comment.
Will automate it with https://github.com/asottile/pyupgrade
|
Great fixes and thanks to other for reviewing this! |
4 participants
For the record, ResourceRequestEvent and ResourceRequestFulfillEvent are also not integrated.