-
Notifications
You must be signed in to change notification settings - Fork 145
Fix some non-python 3 things #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
try: | ||
from StringIO import StringIO | ||
except: | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm struggling to understand how pass
can work here. isnt some kind of StringIO import required in order for the code to be able to work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, I'm fixing this right now.
Hi, reading the code I have only one question which I asked in-line. In general: does the code pass unit testing with python2 and/or python3? |
Both of ggtracker and my fork failed on test_replays with Python3 because of an invalid syntax (Python2 print syntax)
For test_s2gs, it works on my side while it doesn't on the ggtracker version, because of what I've changed. Nothing seems to have changed for Python2. |
Hi @DasFranck sorry for the delay. |
Yes, that's exactly what I meant. |
@DasFranck so funny we should talk about this, someone just asked on twitter about python3 support and now I can tell them we do! Thank you. |
good job @DasFranck 👍 |
There's some few things which doesn't works with python3.
Quick-fixed.